LayoutTests/fast/events/message-port-gc-closed.html - Issue 517043003: Move Frame to the Oilpan heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/message-port-gc-closed.html

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Comments + fix fast/events/message-port-gc-closed.html Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html ('K') | « LayoutTests/fast/dom/Window/resources/window-property-collector.js ('k') | Source/bindings/core/v8/PageScriptDebugServer.cpp » ('j') | Source/core/frame/DOMWindowProperty.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <body>	2 <body>

3 <script src="../../resources/js-test.js"></script>	3 <script src="../../resources/js-test.js"></script>

4 <script>	4 <script>

5 jsTestIsAsync = true;	5 jsTestIsAsync = true;

6 description("MessagePorts (and their execution contexts) should be collected by GC once close() has been called on them");	6 description("MessagePorts (and their execution contexts) should be collected by GC once close() has been called on them");

7 window.onmessage = function(evt) {	7 function finishTest() {

8 iframeDocGC = internals.observeGC(document.querySelector('iframe').contentDo cument);	8 iframeDocGC = internals.observeGC(document.querySelector('iframe').contentDo cument);

9 document.querySelector('iframe').remove();	9 document.querySelector('iframe').remove();

10 gc();	10 gc();
	Mads Ager (chromium) 2014/09/16 12:17:44 Now that we are touching this test we should make Now that we are touching this test we should make this asyncGC to make sure that we get a precise GC at the event loop. Otherwise the test can flake because of values on the stack being treated as a pointer to the frame.
11 shouldBeTrue("iframeDocGC.wasCollected");	11 shouldBeTrue("iframeDocGC.wasCollected");

12 finishJSTest();	12 finishJSTest();

13 }	13 }

	14 window.onmessage = function(evt) {

	15 // The iframe is reachable via evt.source, and evt is on the
	Mads Ager (chromium) 2014/09/16 12:17:44 asyncGC above should solve this issue reliably by asyncGC above should solve this issue reliably by using a precise GC at the event loop. sof 2014/09/17 09:42:57 Thanks, much tidier that way; done. Show quoted text On 2014/09/16 12:17:44, Mads Ager (chromium) wrote: > asyncGC above should solve this issue reliably by using a precise GC at the > event loop. Thanks, much tidier that way; done.
	16 // stack, so restart the test once that reference has gone out of

	17 // scope.

	18 setTimeout(finishTest, 0);

	19 }

14 </script>	20 </script>

15 <iframe src="resources/message-port-gc-closed-iframe.html"></iframe>	21 <iframe src="resources/message-port-gc-closed-iframe.html"></iframe>

16 </body>	22 </body>

OLD	NEW