Move Frame to the Oilpan heap.

Source/web/WebViewImpl.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebViewImpl_h
 #define WebViewImpl_h
 
 #include "core/page/PagePopupDriver.h"
 #include "platform/geometry/IntPoint.h"
 #include "platform/geometry/IntRect.h"
 #include "platform/graphics/GraphicsLayer.h"
+#include "platform/heap/Handle.h"
 #include "public/platform/WebGestureCurveTarget.h"
 #include "public/platform/WebLayer.h"
 #include "public/platform/WebPoint.h"
 #include "public/platform/WebRect.h"
 #include "public/platform/WebSize.h"
 #include "public/platform/WebString.h"
 #include "public/web/WebInputEvent.h"
 #include "public/web/WebNavigationPolicy.h"
 #include "public/web/WebView.h"
 #include "web/BackForwardClientImpl.h"
@@ skipping 17 matching lines @@
 class DataObject;
 class Frame;
 class FullscreenController;
 class LinkHighlight;
 class PopupContainer;
 class RenderLayerCompositor;
 class UserGestureToken;
 class WebActiveGestureAnimation;
 class WebDevToolsAgentPrivate;
 class WebLocalFrameImpl;
+class WebRemoteFrameImpl;
 class WebImage;
 class WebPagePopupImpl;
 class WebPlugin;
 class WebSettingsImpl;
 
 class WebViewImpl FINAL : public WebView
     , public RefCounted<WebViewImpl>
     , public WebGestureCurveTarget
     , public PagePopupDriver
     , public PageWidgetEventHandler {
@@ skipping 509 matching lines @@
     bool m_fixedLayoutSizeLock;
     // If true, automatically resize the render view around its content.
     bool m_shouldAutoResize;
     // The lower bound on the size when auto-resizing.
     IntSize m_minAutoSize;
     // The upper bound on the size when auto-resizing.
     IntSize m_maxAutoSize;
 
     OwnPtrWillBePersistent<Page> m_page;
 
+#if ENABLE(OILPAN)
+    // With Oilpan, the WebViewImpl object keeps a strong reference to one kind of main
+    // frame, so as to keep it alive until the view lets it go.
+    //
+    // In the non-Oilpan case, the ref-counted frame is instead created and returned with
+    // a ref count that must be balanced by eventually calling close() on the
+    // Web*FrameImpl object. That close() call is also assumed for Oilpan, but we need
+    // to keep the object alive until that time. Hence these mutually-exclusive Persistent<>s.
+    Persistent<WebLocalFrameImpl> m_localMainFrame;
+    Persistent<WebRemoteFrameImpl> m_remoteMainFrame;

[dcheng, 2014/09/11 17:03:10]

Page also has a main frame field. It feels redundant to maintain two of them.
Why can't we just make Page's m_mainFrame Persistent?

[sof, 2014/09/12 10:06:21]

This is about retaining the Web{Local,Remote}FrameImpl GCed objects, Page keeps
a Frame. Something close to the web view will have to keep those alive, I think.

But how to represent Page::m_mainFrame in Oilpan is something that needs to be
tidied up.

+#endif
+
     // An object that can be used to manipulate m_page->settings() without linking
     // against WebCore. This is lazily allocated the first time GetWebSettings()
     // is called.
     OwnPtr<WebSettingsImpl> m_webSettings;
 
     // A copy of the web drop data object we received from the browser.
     RefPtrWillBePersistent<DataObject> m_currentDragData;
 
     // The point relative to the client area where the mouse was last pressed
     // down. This is used by the drag client to determine what was under the
@@ skipping 87 matching lines @@
     bool m_recreatingGraphicsContext;
     static const WebInputEvent* m_currentInputEvent;
 
     MediaKeysClientImpl m_mediaKeysClientImpl;
     OwnPtr<WebActiveGestureAnimation> m_gestureAnimation;
     WebPoint m_positionOnFlingStart;
     WebPoint m_globalPositionOnFlingStart;
     int m_flingModifier;
     bool m_flingSourceDevice;
     Vector<OwnPtr<LinkHighlight> > m_linkHighlights;
-    OwnPtr<FullscreenController> m_fullscreenController;
+    OwnPtrWillBePersistent<FullscreenController> m_fullscreenController;
 
     bool m_showFPSCounter;
     bool m_showPaintRects;
     bool m_showDebugBorders;
     bool m_continuousPaintingEnabled;
     bool m_showScrollBottleneckRects;
     WebColor m_baseBackgroundColor;
     WebColor m_backgroundColorOverride;
     float m_zoomFactorOverride;
 
     bool m_userGestureObserved;
     float m_topControlsContentOffset;
 };
 
 // We have no ways to check if the specified WebView is an instance of
 // WebViewImpl because WebViewImpl is the only implementation of WebView.
 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
 
 } // namespace blink
 
 #endif