Source/core/frame/DOMWindowProperty.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/frame/DOMWindowProperty.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased past r181814 conflict Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google, Inc. All Rights Reserved.	2 * Copyright (C) 2011 Google, Inc. All Rights Reserved.

3 * Copyright (C) 2012 Apple Inc. All Rights Reserved.	3 * Copyright (C) 2012 Apple Inc. All Rights Reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
54 // all registrations. Hence no need to unregister.	54 // all registrations. Hence no need to unregister.

55 m_frame = nullptr;	55 m_frame = nullptr;

56 }	56 }

57	57

58 void DOMWindowProperty::willDetachGlobalObjectFromFrame()	58 void DOMWindowProperty::willDetachGlobalObjectFromFrame()

59 {	59 {

60 // If the property is getting this callback it must have been created with a LocalFrame/LocalDOMWindow and it should still have them.	60 // If the property is getting this callback it must have been created with a LocalFrame/LocalDOMWindow and it should still have them.

61 ASSERT(m_frame);	61 ASSERT(m_frame);

62 }	62 }

63	63

	64 void DOMWindowProperty::trace(Visitor* visitor)

	65 {

	66 visitor->trace(m_frame);

	67 }

	68

64 } // namespace blink	69 } // namespace blink

OLD	NEW

« no previous file with comments | « Source/core/frame/DOMWindowProperty.h ('k') | Source/core/frame/Frame.h » ('j') | Source/core/frame/Frame.cpp » ('J')