Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: Source/core/plugins/DOMMimeType.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase past r181764 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 2 Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
3 3
4 This library is free software; you can redistribute it and/or 4 This library is free software; you can redistribute it and/or
5 modify it under the terms of the GNU Library General Public 5 modify it under the terms of the GNU Library General Public
6 License as published by the Free Software Foundation; either 6 License as published by the Free Software Foundation; either
7 version 2 of the License, or (at your option) any later version. 7 version 2 of the License, or (at your option) any later version.
8 8
9 This library is distributed in the hope that it will be useful, 9 This library is distributed in the hope that it will be useful,
10 but WITHOUT ANY WARRANTY; without even the implied warranty of 10 but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 17 matching lines...) Expand all
28 #include "wtf/PassRefPtr.h" 28 #include "wtf/PassRefPtr.h"
29 #include "wtf/RefCounted.h" 29 #include "wtf/RefCounted.h"
30 #include "wtf/RefPtr.h" 30 #include "wtf/RefPtr.h"
31 31
32 namespace blink { 32 namespace blink {
33 33
34 class DOMPlugin; 34 class DOMPlugin;
35 class LocalFrame; 35 class LocalFrame;
36 36
37 class DOMMimeType FINAL : public RefCountedWillBeGarbageCollectedFinalized<DOMMi meType>, public ScriptWrappable, public FrameDestructionObserver { 37 class DOMMimeType FINAL : public RefCountedWillBeGarbageCollectedFinalized<DOMMi meType>, public ScriptWrappable, public FrameDestructionObserver {
38 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DOMMimeType);
38 DEFINE_WRAPPERTYPEINFO(); 39 DEFINE_WRAPPERTYPEINFO();
39 public: 40 public:
40 static PassRefPtrWillBeRawPtr<DOMMimeType> create(PassRefPtr<PluginData> plu ginData, LocalFrame* frame, unsigned index) 41 static PassRefPtrWillBeRawPtr<DOMMimeType> create(PassRefPtr<PluginData> plu ginData, LocalFrame* frame, unsigned index)
41 { 42 {
42 return adoptRefWillBeNoop(new DOMMimeType(pluginData, frame, index)); 43 return adoptRefWillBeNoop(new DOMMimeType(pluginData, frame, index));
43 } 44 }
44 virtual ~DOMMimeType(); 45 virtual ~DOMMimeType();
45 46
46 const String& type() const; 47 const String& type() const;
47 String suffixes() const; 48 String suffixes() const;
48 const String& description() const; 49 const String& description() const;
49 PassRefPtrWillBeRawPtr<DOMPlugin> enabledPlugin() const; 50 PassRefPtrWillBeRawPtr<DOMPlugin> enabledPlugin() const;
50 51
51 void trace(Visitor*) { } 52 virtual void trace(Visitor*) OVERRIDE;
haraken 2014/09/11 14:47:25 Nit: This is just dispatching a trace method to a
sof 2014/09/12 12:46:12 And the presence of a virtual dtor ensures that th
zerny-chromium 2014/09/15 06:33:03 We need to keep the trace here because we want all
52 53
53 private: 54 private:
54 const MimeClassInfo& mimeClassInfo() const { return m_pluginData->mimes()[m_ index]; } 55 const MimeClassInfo& mimeClassInfo() const { return m_pluginData->mimes()[m_ index]; }
55 56
56 DOMMimeType(PassRefPtr<PluginData>, LocalFrame*, unsigned index); 57 DOMMimeType(PassRefPtr<PluginData>, LocalFrame*, unsigned index);
57 RefPtr<PluginData> m_pluginData; 58 RefPtr<PluginData> m_pluginData;
58 unsigned m_index; 59 unsigned m_index;
59 }; 60 };
60 61
61 } // namespace blink 62 } // namespace blink
62 63
63 #endif // DOMMimeType_h 64 #endif // DOMMimeType_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698