Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Side by Side Diff: Source/core/frame/RemoteFrameView.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase past r181764 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef RemoteFrameView_h 5 #ifndef RemoteFrameView_h
6 #define RemoteFrameView_h 6 #define RemoteFrameView_h
7 7
8 #include "platform/Widget.h" 8 #include "platform/Widget.h"
9 #include "platform/geometry/IntRect.h" 9 #include "platform/geometry/IntRect.h"
10 #include "platform/heap/Handle.h"
10 11
11 namespace blink { 12 namespace blink {
12 13
13 class RemoteFrame; 14 class RemoteFrame;
14 15
15 class RemoteFrameView : public Widget { 16 class RemoteFrameView : public Widget {
16 public: 17 public:
17 static PassRefPtr<RemoteFrameView> create(RemoteFrame*); 18 static PassRefPtr<RemoteFrameView> create(RemoteFrame*);
18 19
19 virtual ~RemoteFrameView(); 20 virtual ~RemoteFrameView();
20 21
21 virtual bool isRemoteFrameView() const OVERRIDE { return true; } 22 virtual bool isRemoteFrameView() const OVERRIDE { return true; }
22 23
23 RemoteFrame& frame() const { return *m_remoteFrame; } 24 RemoteFrame& frame() const { return *m_remoteFrame; }
24 25
25 // Override to notify remote frame that its viewport size has changed. 26 // Override to notify remote frame that its viewport size has changed.
26 virtual void frameRectsChanged() OVERRIDE; 27 virtual void frameRectsChanged() OVERRIDE;
27 28
28 virtual void invalidateRect(const IntRect&) OVERRIDE; 29 virtual void invalidateRect(const IntRect&) OVERRIDE;
29 30
30 virtual void setFrameRect(const IntRect&) OVERRIDE; 31 virtual void setFrameRect(const IntRect&) OVERRIDE;
31 32
32 private: 33 private:
33 explicit RemoteFrameView(RemoteFrame*); 34 explicit RemoteFrameView(RemoteFrame*);
34 35
35 RefPtr<RemoteFrame> m_remoteFrame; 36 RefPtrWillBePersistent<RemoteFrame> m_remoteFrame;
haraken 2014/09/11 14:47:25 Add a comment about how the cycle between RemoteFr
sof 2014/09/12 14:47:40 Done, cross-referencing the FrameView::m_frame com
36 }; 37 };
37 38
38 DEFINE_TYPE_CASTS(RemoteFrameView, Widget, widget, widget->isRemoteFrameView(), widget.isRemoteFrameView()); 39 DEFINE_TYPE_CASTS(RemoteFrameView, Widget, widget, widget->isRemoteFrameView(), widget.isRemoteFrameView());
39 40
40 } // namespace blink 41 } // namespace blink
41 42
42 #endif // RemoteFrameView_h 43 #endif // RemoteFrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698