Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase past r181764 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2492 matching lines...) Expand 10 before | Expand all | Expand 10 after
2503 return; 2503 return;
2504 2504
2505 m_needsUpdateWidgetPositions = false; 2505 m_needsUpdateWidgetPositions = false;
2506 2506
2507 updateWidgetPositions(); 2507 updateWidgetPositions();
2508 } 2508 }
2509 2509
2510 void FrameView::updateLayoutAndStyleForPainting() 2510 void FrameView::updateLayoutAndStyleForPainting()
2511 { 2511 {
2512 // Updating layout can run script, which can tear down the FrameView. 2512 // Updating layout can run script, which can tear down the FrameView.
2513 RefPtr<FrameView> protector(this); 2513 RefPtr<FrameView> protect(this);
2514 2514
2515 updateLayoutAndStyleIfNeededRecursive(); 2515 updateLayoutAndStyleIfNeededRecursive();
2516 2516
2517 updateWidgetPositionsIfNeeded(); 2517 updateWidgetPositionsIfNeeded();
2518 2518
2519 RenderView* view = renderView(); 2519 RenderView* view = renderView();
2520 if (view) { 2520 if (view) {
2521 TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "Up dateLayerTree", "frame", m_frame.get()); 2521 TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "Up dateLayerTree", "frame", m_frame.get());
2522 // FIXME(361045): remove InspectorInstrumentation calls once DevTools Ti meline migrates to tracing. 2522 // FIXME(361045): remove InspectorInstrumentation calls once DevTools Ti meline migrates to tracing.
2523 InspectorInstrumentation::willUpdateLayerTree(m_frame.get()); 2523 InspectorInstrumentation::willUpdateLayerTree(m_frame.get());
(...skipping 452 matching lines...) Expand 10 before | Expand all | Expand 10 after
2976 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 2976 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
2977 { 2977 {
2978 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 2978 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
2979 if (AXObjectCache* cache = axObjectCache()) { 2979 if (AXObjectCache* cache = axObjectCache()) {
2980 cache->remove(scrollbar); 2980 cache->remove(scrollbar);
2981 cache->handleScrollbarUpdate(this); 2981 cache->handleScrollbarUpdate(this);
2982 } 2982 }
2983 } 2983 }
2984 2984
2985 } // namespace blink 2985 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698