Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Side by Side Diff: Source/web/WebFrame.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update OilpanExpectations Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "public/web/WebFrame.h" 6 #include "public/web/WebFrame.h"
7 7
8 #include "core/frame/RemoteFrame.h" 8 #include "core/frame/RemoteFrame.h"
9 #include "core/html/HTMLFrameOwnerElement.h" 9 #include "core/html/HTMLFrameOwnerElement.h"
10 #include "platform/UserGestureIndicator.h" 10 #include "platform/UserGestureIndicator.h"
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 , m_opener(0) 213 , m_opener(0)
214 , m_openedFrameTracker(new OpenedFrameTracker) 214 , m_openedFrameTracker(new OpenedFrameTracker)
215 { 215 {
216 } 216 }
217 217
218 WebFrame::~WebFrame() 218 WebFrame::~WebFrame()
219 { 219 {
220 m_openedFrameTracker.reset(0); 220 m_openedFrameTracker.reset(0);
221 } 221 }
222 222
223 void WebFrame::trace(Visitor* visitor, WebFrame* frame)
haraken 2014/09/08 07:25:59 It looks dangerous to do something non-trivial in
sof 2014/09/08 21:17:46 Perhaps the (static) method should be renamed as t
224 {
225 #if ENABLE(OILPAN)
226 // Trace the children frames.
227 WebFrame* child = frame ? frame->firstChild() : 0;
228 while (child) {
229 if (child->isWebLocalFrame())
230 visitor->trace(toWebLocalFrameImpl(child));
231 else
232 visitor->trace(toWebRemoteFrameImpl(child));
233
234 child = child->nextSibling();
235 }
236 #endif
237 }
238
223 } // namespace blink 239 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698