Move Frame to the Oilpan heap.

Source/web/ExternalPopupMenu.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 38 matching lines @@
 class WebViewImpl;
 struct WebPopupMenuInfo;
 
 // The ExternalPopupMenu connects the actual implementation of the popup menu
 // to the WebCore popup menu.
 class ExternalPopupMenu FINAL : public PopupMenu, public WebExternalPopupMenuClient {
 public:
     ExternalPopupMenu(LocalFrame&, PopupMenuClient*, WebViewImpl&);
     virtual ~ExternalPopupMenu();
 
-
     // Fills |info| with the popup menu information contained in the
     // PopupMenuClient associated with this ExternalPopupMenu.
     // FIXME: public only for test access. Need to revert once gtest
     // helpers from chromium are available for blink.
     static void getPopupMenuInfo(WebPopupMenuInfo&, PopupMenuClient&);
     static int toPopupMenuItemIndex(int index, PopupMenuClient&);
     static int toExternalPopupMenuItemIndex(int index, PopupMenuClient&);
 
+    virtual void trace(Visitor*) OVERRIDE;
+
 private:
     // PopupMenu methods:
     virtual void show(const FloatQuad& controlPosition, const IntSize&, int index) OVERRIDE;
     virtual void hide() OVERRIDE;
     virtual void updateFromElement() OVERRIDE;
     virtual void disconnectClient() OVERRIDE;
 
     // WebExternalPopupClient methods:
     virtual void didChangeSelection(int index) OVERRIDE;
     virtual void didAcceptIndex(int index) OVERRIDE;
     virtual void didAcceptIndices(const WebVector<int>& indices) OVERRIDE;
     virtual void didCancel() OVERRIDE;
 
     void dispatchEvent(Timer<ExternalPopupMenu>*);
 
     PopupMenuClient* m_popupMenuClient;
-    RefPtr<LocalFrame> m_localFrame;
+    RefPtrWillBeMember<LocalFrame> m_localFrame;
     WebViewImpl& m_webView;
     OwnPtr<WebMouseEvent> m_syntheticEvent;
     Timer<ExternalPopupMenu> m_dispatchEventTimer;
     // The actual implementor of the show menu.
     WebExternalPopupMenu* m_webExternalPopupMenu;

[haraken, 2014/09/08 07:25:59]

Are you sure that ExternalPopupMenu does not outlive m_popupMenuClient and
m_webExternalPopupMenu? If ExternalPopupMenu outlives them, they will become
dangling pointers.

[sof, 2014/09/08 21:17:46]

m_webExternalPopupMenu is explicitly close()d when ExternalPopupMenu is
disconnected, so this should be the same with or without Oilpan. Right?

PopupMenuClient is a platform object not on the heap, so I don't see any (new)
lifetime issue.

 };
 
 } // namespace blink
 
 #endif // ExternalPopupMenu_h