Move Frame to the Oilpan heap.

Source/core/editing/FrameSelection.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 219 matching lines @@
     if (!m_frame) {
         m_selection = s;
         return;
     }
 
     // <http://bugs.webkit.org/show_bug.cgi?id=23464>: Infinite recursion at FrameSelection::setSelection
     // if document->frame() == m_frame we can get into an infinite loop
     if (s.base().anchorNode()) {
         Document& document = *s.base().document();
         if (document.frame() && document.frame() != m_frame && document != m_frame->document()) {
-            RefPtr<LocalFrame> guard = document.frame();
+            RefPtrWillBeRawPtr<LocalFrame> guard(document.frame());
             document.frame()->selection().setSelection(s, options, align, granularity);
             // It's possible that during the above set selection, this FrameSelection has been modified by
             // selectFrameElementInParentIfFullySelected, but that the selection is no longer valid since
             // the frame is about to be destroyed. If this is the case, clear our selection.
+#if ENABLE(OILPAN)
+            if (guard->hasBeenClosed() && !m_selection.isNonOrphanedCaretOrRange())
+#else
             if (guard->hasOneRef() && !m_selection.isNonOrphanedCaretOrRange())

[haraken, 2014/09/08 07:25:57]

Would it be possible to use guard->hasBeenClosed() in non-oilpan builds as well?
(To make it workable, we'll need to enable the close call in non-oilpan builds.)

We don't want to have different call paths between oilpan builds and non-oilpan
builds as much as possible.

[sof, 2014/09/11 13:27:05]

Overloooked previously; now done.

+#endif
                 clear();
             return;
         }
     }
 
     m_granularity = granularity;
 
     if (closeTyping)
         TypingCommand::closeTyping(m_frame);
 
@@ skipping 911 matching lines @@
     m_granularity = CharacterGranularity;
     setSelection(VisibleSelection());
 }
 
 void FrameSelection::prepareForDestruction()
 {
     m_granularity = CharacterGranularity;
 
     m_caretBlinkTimer.stop();
 
-    RenderView* view = m_frame->contentRenderer();
-    if (view)
-        view->clearSelection();
+    if (FrameView* view = m_frame->view())
+        view->clear();

[haraken, 2014/09/08 07:25:57]

What is this change for?

[sof, 2014/09/08 21:17:45]

It does not belong here; reverted.

 
     setSelection(VisibleSelection(), CloseTyping | ClearTypingStyle | DoNotUpdateAppearance);
     m_previousCaretNode.clear();
 }
 
 void FrameSelection::setStart(const VisiblePosition &pos, EUserTriggered trigger)
 {
     if (m_selection.isBaseFirst())
         setBase(pos, trigger);
     else
@@ skipping 701 matching lines @@
 
 void FrameSelection::showTreeForThis() const
 {
     m_selection.showTreeForThis();
 }
 
 #endif
 
 void FrameSelection::trace(Visitor* visitor)
 {
+    visitor->trace(m_frame);
     visitor->trace(m_selection);
     visitor->trace(m_originalBase);
     visitor->trace(m_logicalRange);
     visitor->trace(m_previousCaretNode);
     visitor->trace(m_typingStyle);
     VisibleSelection::ChangeObserver::trace(visitor);
 }
 
 void FrameSelection::setCaretRectNeedsUpdate()
 {
@@ skipping 19 matching lines @@
     sel.showTreeForThis();
 }
 
 void showTree(const blink::FrameSelection* sel)
 {
     if (sel)
         sel->showTreeForThis();
 }
 
 #endif