Move Frame to the Oilpan heap.

Source/web/WebRemoteFrameImpl.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "web/WebRemoteFrameImpl.h"
 
 #include "core/frame/FrameOwner.h"
 #include "core/frame/RemoteFrame.h"
 #include "core/frame/Settings.h"
 #include "core/page/Page.h"
+#include "platform/heap/Handle.h"
 #include "public/platform/WebFloatRect.h"
 #include "public/platform/WebRect.h"
 #include "public/web/WebDocument.h"
 #include "public/web/WebPerformance.h"
 #include "public/web/WebRange.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebViewImpl.h"
 #include <v8/include/v8.h>
 
 namespace blink {
 
 namespace {
 
 // Helper class to bridge communication for a local frame with a remote parent.
 // Currently, it serves two purposes:
 // 1. Allows the local frame's loader to retrieve sandbox flags associated with
 //    its owner element in another process.
 // 2. Trigger a load event on its owner element once it finishes a load.
-class RemoteBridgeFrameOwner : public FrameOwner {
+class RemoteBridgeFrameOwner : public NoBaseWillBeGarbageCollectedFinalized<RemoteBridgeFrameOwner>, public FrameOwner {
+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RemoteBridgeFrameOwner);
 public:
-    explicit RemoteBridgeFrameOwner(PassRefPtr<WebLocalFrameImpl>);
+    static PassOwnPtrWillBeRawPtr<RemoteBridgeFrameOwner> create(PassRefPtrWillBeRawPtr<WebLocalFrameImpl> frame)
+    {
+        return adoptPtrWillBeNoop(new RemoteBridgeFrameOwner(frame));
+    }
 
     virtual bool isLocal() const OVERRIDE;
     virtual SandboxFlags sandboxFlags() const OVERRIDE;
     virtual void dispatchLoad() OVERRIDE;
 
+    virtual void trace(Visitor*);
+
 private:
-    RefPtr<WebLocalFrameImpl> m_frame;
+    explicit RemoteBridgeFrameOwner(PassRefPtrWillBeRawPtr<WebLocalFrameImpl>);
+
+    RefPtrWillBeMember<WebLocalFrameImpl> m_frame;
 };
 
-RemoteBridgeFrameOwner::RemoteBridgeFrameOwner(PassRefPtr<WebLocalFrameImpl> frame)
+RemoteBridgeFrameOwner::RemoteBridgeFrameOwner(PassRefPtrWillBeRawPtr<WebLocalFrameImpl> frame)
     : m_frame(frame)
 {
 }
 
+void RemoteBridgeFrameOwner::trace(Visitor* visitor)
+{
+    visitor->trace(m_frame);
+    FrameOwner::trace(visitor);
+}
+
 bool RemoteBridgeFrameOwner::isLocal() const
 {
     return false;
 }
 
 SandboxFlags RemoteBridgeFrameOwner::sandboxFlags() const
 {
     // FIXME: Implement. Most likely grab it from m_frame.
     return 0;
 }
 
 void RemoteBridgeFrameOwner::dispatchLoad()
 {
     // FIXME: Implement. Most likely goes through m_frame->client().
 }
 
 // FIXME: This is just a placeholder frame owner to supply to RemoteFrame when
 // the parent is also a remote frame. Strictly speaking, this shouldn't be
 // necessary, since a remote frame shouldn't ever need to communicate with a
 // remote parent (there are no sandbox flags to retrieve in this case, nor can
 // the RemoteFrame itself load a document). In most circumstances, the check for
 // frame->owner() can be replaced with a check for frame->tree().parent(). Once
 // that's done, this class can be removed.
-class PlaceholderFrameOwner : public FrameOwner {
+class PlaceholderFrameOwner : public NoBaseWillBeGarbageCollectedFinalized<PlaceholderFrameOwner>, public FrameOwner {
+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PlaceholderFrameOwner);
 public:
     virtual bool isLocal() const OVERRIDE;
     virtual SandboxFlags sandboxFlags() const OVERRIDE;
     virtual void dispatchLoad() OVERRIDE;
 };
 
 bool PlaceholderFrameOwner::isLocal() const
 {
     return false;
 }
 
 SandboxFlags PlaceholderFrameOwner::sandboxFlags() const
 {
     ASSERT_NOT_REACHED();
     return 0;
 }
 
 void PlaceholderFrameOwner::dispatchLoad()
 {
     ASSERT_NOT_REACHED();
 }
 
 } // namespace
 
 WebRemoteFrame* WebRemoteFrame::create(WebFrameClient*)
 {
-    return adoptRef(new WebRemoteFrameImpl()).leakRef();
+    WebRemoteFrameImpl* frame = new WebRemoteFrameImpl();
+#if ENABLE(OILPAN)
+    return frame;
+#else
+    return adoptRef(frame).leakRef();
+#endif
 }
 
 WebRemoteFrameImpl::WebRemoteFrameImpl()
     : m_frameClient(this)
 {
 }
 
 WebRemoteFrameImpl::~WebRemoteFrameImpl()
 {
 }
 
+void WebRemoteFrameImpl::trace(Visitor* visitor)
+{
+#if ENABLE(OILPAN)
+    visitor->trace(m_frame);
+    visitor->trace(m_ownersForChildren);
+
+    WebFrame::trace(visitor, this);
+#endif
+}
+
 bool WebRemoteFrameImpl::isWebLocalFrame() const
 {
     return false;
 }
 
 WebLocalFrame* WebRemoteFrameImpl::toWebLocalFrame()
 {
     ASSERT_NOT_REACHED();
     return 0;
 }
 
 bool WebRemoteFrameImpl::isWebRemoteFrame() const
 {
     return true;
 }
 
 WebRemoteFrame* WebRemoteFrameImpl::toWebRemoteFrame()
 {
     return this;
 }
 
 void WebRemoteFrameImpl::close()
 {
+#if ENABLE(OILPAN)
+    if (m_frame)
+        m_frame->willBeDestroyed();
+#else
     deref();
+#endif
 }
 
 WebString WebRemoteFrameImpl::uniqueName() const
 {
     ASSERT_NOT_REACHED();
     return WebString();
 }
 
 WebString WebRemoteFrameImpl::assignedName() const
 {
@@ skipping 647 matching lines @@
 
 WebString WebRemoteFrameImpl::layerTreeAsText(bool showDebugInfo) const
 {
     ASSERT_NOT_REACHED();
     return WebString();
 }
 
 WebLocalFrame* WebRemoteFrameImpl::createLocalChild(const WebString& name, WebFrameClient* client)
 {
     WebLocalFrameImpl* child = toWebLocalFrameImpl(WebLocalFrame::create(client));
-    HashMap<WebFrame*, OwnPtr<FrameOwner> >::AddResult result =
-        m_ownersForChildren.add(child, adoptPtr(new RemoteBridgeFrameOwner(child)));
+    WillBeHeapHashMap<WebFrame*, OwnPtrWillBeMember<FrameOwner> >::AddResult result =
+        m_ownersForChildren.add(child, RemoteBridgeFrameOwner::create(child));
     appendChild(child);
     // FIXME: currently this calls LocalFrame::init() on the created LocalFrame, which may
     // result in the browser observing two navigations to about:blank (one from the initial
     // frame creation, and one from swapping it into the remote process). FrameLoader might
     // need a special initialization function for this case to avoid that duplicate navigation.
     child->initializeCoreFrame(frame()->host(), result.storedValue->value.get(), name, nullAtom);
     // Partially related with the above FIXME--the init() call may trigger JS dispatch. However,
     // if the parent is remote, it should never be detached synchronously...
     ASSERT(child->frame());
     return child;
 }
 
 void WebRemoteFrameImpl::initializeCoreFrame(FrameHost* host, FrameOwner* owner, const AtomicString& name)
 {
     setCoreFrame(RemoteFrame::create(&m_frameClient, host, owner));
     m_frame->tree().setName(name, nullAtom);
 }
 
 WebRemoteFrame* WebRemoteFrameImpl::createRemoteChild(const WebString& name, WebFrameClient* client)
 {
     WebRemoteFrameImpl* child = toWebRemoteFrameImpl(WebRemoteFrame::create(client));
-    HashMap<WebFrame*, OwnPtr<FrameOwner> >::AddResult result =
-        m_ownersForChildren.add(child, adoptPtr(new PlaceholderFrameOwner));
+    WillBeHeapHashMap<WebFrame*, OwnPtrWillBeMember<FrameOwner> >::AddResult result =
+        m_ownersForChildren.add(child, adoptPtrWillBeNoop(new PlaceholderFrameOwner));
     appendChild(child);
     child->initializeCoreFrame(frame()->host(), result.storedValue->value.get(), name);
     return child;
 }
 
-void WebRemoteFrameImpl::setCoreFrame(PassRefPtr<RemoteFrame> frame)
+void WebRemoteFrameImpl::setCoreFrame(PassRefPtrWillBeRawPtr<RemoteFrame> frame)
 {
     m_frame = frame;

[Mads Ager (chromium), 2014/09/03 10:07:54]

In the oilpan build, shouldn't we do a willBeDestroyed notification if m_frame
is not null?

 }
 
 WebRemoteFrameImpl* WebRemoteFrameImpl::fromFrame(RemoteFrame& frame)
 {
     if (!frame.client())
         return 0;
     return static_cast<RemoteFrameClient*>(frame.client())->webFrame();
 }
 
 } // namespace blink
-