Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 517033002: Make SkGpuDevice constructors private. (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix GpuDrawPatTest #

Patch Set 3 : remove extra ) #

Patch Set 4 : Fix SampleApp.cpp #

Patch Set 5 : more replacements of cons with factory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M debugger/QT/SkGLWidget.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 2 chunks +4 lines, -14 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
bsalomon
bsalomon@google.com changed reviewers: + robertphillips@google.com
6 years, 3 months ago (2014-08-28 20:28:52 UTC) #1
bsalomon
6 years, 3 months ago (2014-08-28 20:28:52 UTC) #2
robertphillips
lgtm
6 years, 3 months ago (2014-08-28 20:29:36 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 3 months ago (2014-08-28 20:31:05 UTC) #4
bsalomon
The CQ bit was unchecked by bsalomon@google.com
6 years, 3 months ago (2014-08-28 20:31:17 UTC) #5
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 3 months ago (2014-08-28 20:32:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/517033002/40001
6 years, 3 months ago (2014-08-28 20:32:50 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86_64-Release-Trybot on tryserver.skia ...
6 years, 3 months ago (2014-08-28 20:40:19 UTC) #8
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 3 months ago (2014-08-28 20:42:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/517033002/60001
6 years, 3 months ago (2014-08-28 20:42:30 UTC) #10
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 3 months ago (2014-08-28 20:52:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/517033002/80001
6 years, 3 months ago (2014-08-28 20:52:50 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 21:06:45 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as 23b406cc040d55b45acc96e63db5c2d5c934a53c

Powered by Google App Engine
This is Rietveld 408576698