Issue 517031: linux: work around LAHF bug in Flash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 517031: linux: work around LAHF bug in Flash (Closed)

Created:
10 years, 11 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
agl, Markus (顧孟勤)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam

Visibility:
Public.

Description

linux: work around LAHF bug in Flash 64-bit Flash uses the LAHF instruction, which isn't available on some CPUs. Work around this by catching SIGILL and emulating the instruction. BUG=29789 TEST=flash works on more computers than before, nothing else changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35536

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : comment #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -1 line)			Patch
M	chrome/chrome.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/plugin/plugin_main.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download
A	chrome/plugin/plugin_main_linux.cc	View	1 2	1 chunk	+50 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

http://codereview.chromium.org/517031/diff/3001/4003 File chrome/plugin/plugin_main_linux.cc (right): http://codereview.chromium.org/517031/diff/3001/4003#newcode21 chrome/plugin/plugin_main_linux.cc:21: raise(signal); This may overflow the stack.

10 years, 11 months ago (2010-01-04 23:02:43 UTC) #2

Markus (顧孟勤)

10 years, 11 months ago (2010-01-05 02:19:13 UTC) #3

Looks good to me (with the bunch of changes that I gave you offline).

On Mon, Jan 4, 2010 at 14:55, <evan@chromium.org> wrote:

> Reviewers: agl, Markus (顧孟勤),
>
> Description:
> linux: work around LAHF bug in Flash
>
> 64-bit Flash uses the LAHF instruction, which isn't available on
> some CPUs.  Work around this by catching SIGILL and emulating
> the instruction.
>
> BUG=29789
> TEST=flash works on more computers than before, nothing else changes
>
> Please review this at http://codereview.chromium.org/517031
>
> Affected files:
>  M chrome/chrome.gyp
>  M chrome/plugin/plugin_main.cc
>  A chrome/plugin/plugin_main_linux.cc
>
>
>

Expand Messages | Collapse Messages