Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 517023003: Add dirty_after_edit to SkPath::moveTo. Add commented out test case that triggers assert. (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add dirty_after_edit to SkPath::moveTo. Add commented out test case that triggers assert. BUG=skia:1460 Committed: https://skia.googlesource.com/skia/+/b17c1291085e50819c0c46aae783067c30a67516

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/core/SkPath.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PathTest.cpp View 1 2 2 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
bsalomon@google.com changed reviewers: + reed@google.com
6 years, 3 months ago (2014-08-28 20:28:24 UTC) #1
bsalomon
6 years, 3 months ago (2014-08-28 20:28:24 UTC) #2
reed1
lgtm
6 years, 3 months ago (2014-08-28 20:49:33 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 3 months ago (2014-08-28 20:52:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/517023003/40001
6 years, 3 months ago (2014-08-28 20:53:50 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 21:04:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as b17c1291085e50819c0c46aae783067c30a67516

Powered by Google App Engine
This is Rietveld 408576698