Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 516953003: Removing "using" declarations that import names in the C++ Standard library.(Source/platform/[fonts… (Closed)

Created:
6 years, 3 months ago by shreeramk
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removing "using" declarations that import names in the C++ Standard library.(Source/platform/[fonts,text]) This is as per the the coding guidelines for blink. Do not use "using" declarations of any kind to import names in the standard template library. Directly qualify the names at the point they're used instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181130

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -78 lines) Patch
M Source/platform/fonts/Font.cpp View 9 chunks +16 lines, -17 lines 1 comment Download
M Source/platform/fonts/FontPlatformData.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/fonts/SimpleFontData.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/platform/fonts/WidthIterator.cpp View 3 chunks +6 lines, -7 lines 0 comments Download
M Source/platform/fonts/mac/ComplexTextController.cpp View 7 chunks +14 lines, -16 lines 0 comments Download
M Source/platform/fonts/mac/FontComplexTextMac.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/fonts/mac/SimpleFontDataMac.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/fonts/opentype/OpenTypeVerticalData.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/text/LocaleICU.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/text/LocaleMac.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/text/LocaleWin.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/text/TextBreakIteratorICU.cpp View 10 chunks +17 lines, -18 lines 0 comments Download
M Source/platform/text/TextStream.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
shreeramk
Please review. Thanks!
6 years, 3 months ago (2014-08-28 19:45:14 UTC) #1
jamesr
jamesr@chromium.org changed reviewers: + jamesr@chromium.org
6 years, 3 months ago (2014-08-28 19:57:21 UTC) #2
jamesr
lgtm https://codereview.chromium.org/516953003/diff/1/Source/platform/fonts/Font.cpp File Source/platform/fonts/Font.cpp (right): https://codereview.chromium.org/516953003/diff/1/Source/platform/fonts/Font.cpp#newcode372 Source/platform/fonts/Font.cpp:372: return std::make_pair(data, page); given the number of make_pair ...
6 years, 3 months ago (2014-08-28 19:57:21 UTC) #3
shreeramk
On 2014/08/28 19:57:21, jamesr wrote: > lgtm > > https://codereview.chromium.org/516953003/diff/1/Source/platform/fonts/Font.cpp > File Source/platform/fonts/Font.cpp (right): > ...
6 years, 3 months ago (2014-08-29 02:34:18 UTC) #4
jamesr
Hmm, then go back to the std::make_pair<> version. Looks like the style checker and style ...
6 years, 3 months ago (2014-08-29 21:11:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shreeram.k@samsung.com/516953003/1
6 years, 3 months ago (2014-08-30 07:05:55 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 3 months ago (2014-08-30 08:07:51 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-08-30 09:09:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181130

Powered by Google App Engine
This is Rietveld 408576698