Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7088)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 516943003: Add textfield internal padding from FocusableBorder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restore Insets const ref. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/find_bar_view.cc ('k') | ui/app_list/views/folder_header_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index cc226968c668f77c0591af2f8d498a0a712107e4..a22cb6d9ede75b4481918b95416669700ab55c45 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -647,7 +647,6 @@ gfx::Size LocationBarView::GetPreferredSize() const {
leading_width +=
kItemPadding + location_icon_view_->GetMinimumSize().width();
}
- leading_width += kItemPadding - GetEditLeadingInternalSpace();
// Compute width of omnibox-trailing content.
int trailing_width = search_button_->visible() ?
@@ -659,7 +658,7 @@ gfx::Size LocationBarView::GetPreferredSize() const {
IncrementalMinimumWidth(manage_passwords_icon_view_) +
IncrementalMinimumWidth(zoom_view_) +
IncrementalMinimumWidth(generated_credit_card_view_) +
- IncrementalMinimumWidth(mic_search_view_) + kItemPadding;
+ IncrementalMinimumWidth(mic_search_view_);
for (PageActionViews::const_iterator i(page_action_views_.begin());
i != page_action_views_.end(); ++i)
trailing_width += IncrementalMinimumWidth((*i));
@@ -667,8 +666,8 @@ gfx::Size LocationBarView::GetPreferredSize() const {
i != content_setting_views_.end(); ++i)
trailing_width += IncrementalMinimumWidth((*i));
- min_size.set_width(
- leading_width + omnibox_view_->GetMinimumSize().width() + trailing_width);
+ min_size.set_width(leading_width + omnibox_view_->GetMinimumSize().width() +
+ 2 * kItemPadding - omnibox_view_->GetInsets().width() + trailing_width);
return min_size;
}
@@ -684,9 +683,11 @@ void LocationBarView::Layout() {
LocationBarLayout leading_decorations(
LocationBarLayout::LEFT_EDGE,
- kItemPadding - GetEditLeadingInternalSpace());
- LocationBarLayout trailing_decorations(LocationBarLayout::RIGHT_EDGE,
- kItemPadding);
+ kItemPadding - omnibox_view_->GetInsets().left() -
+ GetEditLeadingInternalSpace());
+ LocationBarLayout trailing_decorations(
+ LocationBarLayout::RIGHT_EDGE,
+ kItemPadding - omnibox_view_->GetInsets().right());
const int origin_chip_preferred_width =
origin_chip_view_->GetPreferredSize().width();
@@ -979,9 +980,8 @@ void LocationBarView::Layout() {
}
}
- const gfx::Insets insets = omnibox_view_->GetInsets();
- omnibox_view_->SetBorder(views::Border::CreateEmptyBorder(
- insets.top(), insets.left(), insets.bottom(), omnibox_view_margin));
+ omnibox_view_->SetBorder(
+ views::Border::CreateEmptyBorder(0, 0, 0, omnibox_view_margin));
// Layout |ime_inline_autocomplete_view_| next to the user input.
if (ime_inline_autocomplete_view_->visible()) {
« no previous file with comments | « chrome/browser/ui/views/find_bar_view.cc ('k') | ui/app_list/views/folder_header_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698