Add textfield internal padding from FocusableBorder.

ui/views/controls/focusable_border.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/focusable_border.h"
 
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/insets.h"
 #include "ui/gfx/skia_util.h"
 #include "ui/native_theme/native_theme.h"
 
 namespace {
 
-// Define the size of the insets
-const int kTopInsetSize = 4;
-const int kLeftInsetSize = 4;
-const int kBottomInsetSize = 4;
-const int kRightInsetSize = 4;
+const int kInsetSize = 1;
 
 }  // namespace
 
 namespace views {
 
 FocusableBorder::FocusableBorder()
-    : insets_(kTopInsetSize, kLeftInsetSize,
-              kBottomInsetSize, kRightInsetSize),
+    : insets_(kInsetSize, kInsetSize, kInsetSize, kInsetSize),
       override_color_(SK_ColorWHITE),
       use_default_color_(true) {
 }
 
+FocusableBorder::~FocusableBorder() {
+}
+
 void FocusableBorder::SetColor(SkColor color) {
   override_color_ = color;
   use_default_color_ = false;
 }
 
 void FocusableBorder::UseDefaultColor() {
   use_default_color_ = true;
 }
 
 void FocusableBorder::Paint(const View& view, gfx::Canvas* canvas) {
   SkPath path;
   path.addRect(gfx::RectToSkRect(view.GetLocalBounds()), SkPath::kCW_Direction);
   SkPaint paint;
   paint.setStyle(SkPaint::kStroke_Style);
   SkColor color = override_color_;
   if (use_default_color_) {
     color = view.GetNativeTheme()->GetSystemColor(
         view.HasFocus() ? ui::NativeTheme::kColorId_FocusedBorderColor :
                           ui::NativeTheme::kColorId_UnfocusedBorderColor);
   }
 
   paint.setColor(color);
-  paint.setStrokeWidth(SkIntToScalar(2));
+  paint.setStrokeWidth(SkIntToScalar(2 * kInsetSize));

[Peter Kasting, 2014/08/29 21:09:11]

This probably deserves a comment on why the stroke width is larger than the
inset size.

[msw, 2014/08/30 00:17:48]

I reverted this; it's just drawing a rect at the local bounds with a 2px stroke.
(afaict, 1px is being painted outside the view bounds but it's clipped)

[Peter Kasting, 2014/08/30 00:46:42]

Maybe then we should just draw a kInsetSize-px line centered kInsetSize/2
(floating point) pixels inset from the bounds?  That seems clearer...

[msw, 2014/09/04 01:25:51]

Feel free to rewrite this separately.

 
   canvas->DrawPath(path, paint);
 }
 
 gfx::Insets FocusableBorder::GetInsets() const {
   return insets_;
 }
 
 gfx::Size FocusableBorder::GetMinimumSize() const {
   return gfx::Size();
 }
 
 void FocusableBorder::SetInsets(int top, int left, int bottom, int right) {
   insets_.Set(top, left, bottom, right);
 }
 
 }  // namespace views