Add textfield internal padding from FocusableBorder.

ui/views/controls/textfield/textfield.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #define UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 27 matching lines @@
 class VIEWS_EXPORT Textfield : public View,
                                public TextfieldModel::Delegate,
                                public ContextMenuController,
                                public DragController,
                                public ui::TouchEditable,
                                public ui::TextInputClient {
  public:
   // The textfield's class name.
   static const char kViewClassName[];
 
+  // The preferred size of the padding to be used around textfield text.
+  static const int kTextPadding;

[Peter Kasting, 2014/09/09 01:33:29]

It looks like search_box_view.cc and combobox.cc are the remaining references to
this.  Can they be changed to use inset values as well?  That'd let us move this
to be .cc-file-static.

[msw, 2014/09/09 17:01:06]

Not in a clearly good way.

(1) search_box_view.cc is specifying the padding between BoxLayout views (on the
left and the right of the textfield) in a single value, |kPadding -
views::Textfield::kTextPadding|. I could use the (a) left or right inset value
or (c) divide the overall insets width by two, or (d) rewrite the layout...

(2) combobox.cc doesn't have a textfield instance, I could (a) construct a
textfield instance to get its insets, or (b) duplicate the constant value.
Neither seems great, but I'd do (2b) if we resolve 1...

[Peter Kasting, 2014/09/09 18:27:17]

It'd probably be OK to do (a) and claim that Textfield's insets are always going
to be symmetrical, but it's not so awesome that I'm going to push you to do it.
Oh, so the combobox is just trying to mirror the look of the Textfield, not
actually use one?  Hmm.  Not sure what the best answer is there.  Maybe hoist
the textfield padding constant to be an overall layout constant, or make a
public static Textfield::GetPadding() method, or something...

Nothing seems terrifically awesome, so you're fine doing whatever.

[msw, 2014/09/09 19:57:20]

Then I'll leave this as-is. I see lots of additional opportunities for cleanup
and consolidation, but I need to transition away from my UI responsibilities.

+
   // Returns the text cursor blink time in milliseconds, or 0 for no blinking.
   static size_t GetCaretBlinkMs();
 
   Textfield();
   virtual ~Textfield();
 
   // Set the controller for this textfield.
   void set_controller(TextfieldController* controller) {
     controller_ = controller;
   }
@@ skipping 137 matching lines @@
 
   // Performs the action associated with the specified command id.
   void ExecuteCommand(int command_id);
 
   void SetFocusPainter(scoped_ptr<Painter> focus_painter);
 
   // Returns whether there is a drag operation originating from the textfield.
   bool HasTextBeingDragged();
 
   // View overrides:
+  virtual gfx::Insets GetInsets() const OVERRIDE;
   virtual int GetBaseline() const OVERRIDE;
   virtual gfx::Size GetPreferredSize() const OVERRIDE;
   virtual const char* GetClassName() const OVERRIDE;
   virtual gfx::NativeCursor GetCursor(const ui::MouseEvent& event) OVERRIDE;
   virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE;
   virtual bool OnMouseDragged(const ui::MouseEvent& event) OVERRIDE;
   virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE;
   virtual bool OnKeyPressed(const ui::KeyEvent& event) OVERRIDE;
   virtual ui::TextInputClient* GetTextInputClient() OVERRIDE;
   virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE;
@@ skipping 253 matching lines @@
 
   // Used to bind callback functions to this object.
   base::WeakPtrFactory<Textfield> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Textfield);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_