Add textfield internal padding from FocusableBorder.

ui/app_list/views/search_box_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/search_box_view.h"
 
 #include <algorithm>
 
 #include "ui/app_list/app_list_model.h"
 #include "ui/app_list/app_list_switches.h"
@@ skipping 76 matching lines @@
       speech_button_(NULL),
       search_box_(new views::Textfield),
       contents_view_(NULL) {
   if (switches::IsExperimentalAppListEnabled()) {
     set_background(new SearchBoxBackground());
   } else {
     icon_view_ = new views::ImageView;
     AddChildView(icon_view_);
   }
 
-  views::BoxLayout* layout = new views::BoxLayout(
-      views::BoxLayout::kHorizontal, kPadding, 0, kPadding);
+  views::BoxLayout* layout =
+      new views::BoxLayout(views::BoxLayout::kHorizontal,
+                           kPadding,
+                           0,
+                           kPadding - views::Textfield::kTextPadding);

[calamity, 2014/09/08 03:37:50]

This will change the horizontal spacing of everything in this view. I don't
think that's right.

Since the search box had a NullBorder(), the original issue with the
FocusableBorder doesn't apply?

I think it's best to leave this as it was. The only visual difference will be
that the text shifts 3px to the right (but read comment below first).

[Peter Kasting, 2014/09/08 17:45:59]

Practically-speaking, what's the problematic effect here?  Reducing the padding
between the menu button and the speech button?
The bug wasn't in FocusableBorder, it was that the Textfield wasn't previously
enforcing padding on all sides of its content for all callers.  See my reply to
your other comment.

[calamity, 2014/09/09 00:46:38]

I see. In that case, we should leave the code as it was. The effect of this
change is that the padding between all subviews of the search box (i.e the
search icon, textfield, menu and microphone) will have less padding between
them.

[Peter Kasting, 2014/09/09 01:33:29]

But the textfield padding is increasing.  Compensating for that is why this line
was changed.  That's why I asked specifically about the menu button to speech
button distance, because anything adjacent to a Textfield is _not_ going to
change its overall padding.

[calamity, 2014/09/09 02:34:32]

Ah ok. Yeah. It will reduce that padding. At the moment, those two buttons don't
show together but that could change in the future. We can cross that bridge when
we get to it.

   SetLayoutManager(layout);
   layout->set_cross_axis_alignment(
       views::BoxLayout::CROSS_AXIS_ALIGNMENT_CENTER);
   layout->set_minimum_cross_axis_size(switches::IsExperimentalAppListEnabled()
                                           ? kExperimentalSearchBoxHeight
                                           : kPreferredHeight);
 
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
 
   search_box_->SetBorder(views::Border::NullBorder());
@@ skipping 158 matching lines @@
   NotifyQueryChanged();
 }
 
 void SearchBoxView::OnSpeechRecognitionStateChanged(
     SpeechRecognitionState new_state) {
   SpeechRecognitionButtonPropChanged();
   SchedulePaint();
 }
 
 }  // namespace app_list