Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 516933002: Remove a failing ASSERT(paintInvalidationContainer) (Closed)

Created:
6 years, 3 months ago by philipj_slow
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Remove a failing ASSERT(paintInvalidationContainer) This assert is the cause of a flakiness in a fullscreen test: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fandroid%2Ffullscreen%2Fmodel%2Ffully-exit-fullscreen-nested-iframe.html paintInvalidationContainer can be null here, when coming from RenderObject::selectionRect(). Also note that immediately preceding code checks !paintInvalidationContainer, which wouldn't make sense if it were guaranteed to not be null. Code review which lead to the inclusion of the assert: https://codereview.chromium.org/445793002/diff/80001/Source/core/rendering/RenderView.cpp#newcode512 BUG=408495 TEST=LayoutTests/virtual/android/fullscreen/model/fully-exit-fullscreen-nested-iframe.html R=chrishtr@chromium.org,leviw@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/rendering/RenderView.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
philipj_slow
6 years, 3 months ago (2014-08-28 14:15:49 UTC) #1
PTAL. If there's a quick way to get rid of the null case instead that's great,
this is my quickfix with limited domain knowledge.

Powered by Google App Engine
This is Rietveld 408576698