Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/test_with_scope.cc

Issue 51693002: GN: toolchain threading cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/test_with_scope.h ('k') | tools/gn/toolchain.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/test_with_scope.cc
diff --git a/tools/gn/test_with_scope.cc b/tools/gn/test_with_scope.cc
index e83c99cb060e2bb742744061ac83f63f728f5c38..e149e92d08448a6704dd9582606ab5e6edce5567 100644
--- a/tools/gn/test_with_scope.cc
+++ b/tools/gn/test_with_scope.cc
@@ -6,9 +6,13 @@
TestWithScope::TestWithScope()
: build_settings_(),
- toolchain_(Label(SourceDir("//toolchain/"), "tc")),
- settings_(&build_settings_, &toolchain_, std::string()),
+ settings_(&build_settings_, std::string()),
+ toolchain_(&settings_, Label(SourceDir("//toolchain/"), "default")),
scope_(&settings_) {
+ build_settings_.SetBuildDir(SourceDir("//out/Debug/"));
+
+ settings_.set_toolchain_label(toolchain_.label());
+ settings_.set_is_default(true);
}
TestWithScope::~TestWithScope() {
« no previous file with comments | « tools/gn/test_with_scope.h ('k') | tools/gn/toolchain.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698