Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: tools/gn/target.cc

Issue 51693002: GN: toolchain threading cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/target.h ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index 291d5790d9022fc35705f61a9573983929a14e3d..28dcf91f2da7136c95b6f381d382c1efdf5b4b5e 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -57,8 +57,7 @@ void MergeAllDependentConfigsFrom(const Target* from_target,
} // namespace
Target::Target(const Settings* settings, const Label& label)
- : Item(label),
- settings_(settings),
+ : Item(settings, label),
output_type_(UNKNOWN),
hard_dep_(false),
external_(false),
@@ -155,9 +154,9 @@ void Target::OnResolved() {
}
// Mark as resolved.
- if (!settings_->build_settings()->target_resolved_callback().is_null()) {
+ if (!settings()->build_settings()->target_resolved_callback().is_null()) {
g_scheduler->ScheduleWork(base::Bind(&TargetResolvedThunk,
- settings_->build_settings()->target_resolved_callback(),
+ settings()->build_settings()->target_resolved_callback(),
this));
}
}
« no previous file with comments | « tools/gn/target.h ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698