Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: tools/gn/setup.cc

Issue 51693002: GN: toolchain threading cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/setup.h ('k') | tools/gn/target.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/setup.cc
diff --git a/tools/gn/setup.cc b/tools/gn/setup.cc
index 8bce9b515874394bdc87a9a7fbb7d8b6ddda2122..47a243ace6da2558ac048af0dbb4c9923aa1d92c 100644
--- a/tools/gn/setup.cc
+++ b/tools/gn/setup.cc
@@ -202,9 +202,9 @@ bool CommonSetup::RunPostMessageLoop() {
Setup::Setup()
: CommonSetup(),
- empty_toolchain_(Label()),
- empty_settings_(&empty_build_settings_, &empty_toolchain_, std::string()),
+ empty_settings_(&empty_build_settings_, std::string()),
dotfile_scope_(&empty_settings_) {
+ empty_settings_.set_toolchain_label(Label());
}
Setup::~Setup() {
« no previous file with comments | « tools/gn/setup.h ('k') | tools/gn/target.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698