tools/gn/ninja_helper_unittest.cc - Issue 51693002: GN: toolchain threading cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_helper_unittest.cc

Issue 51693002: GN: toolchain threading cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_helper_unittest.cc

diff --git a/tools/gn/ninja_helper_unittest.cc b/tools/gn/ninja_helper_unittest.cc

index 6e3b25c07136307b7d427fd49a3b5a318bad007f..63082bc34e40550e905883a70d9589e05a58ba35 100644

--- a/tools/gn/ninja_helper_unittest.cc

+++ b/tools/gn/ninja_helper_unittest.cc

@@ -17,9 +17,10 @@ class HelperSetterUpper {

public:

HelperSetterUpper()

: build_settings(),

- toolchain(Label(SourceDir("//"), "tc")),

- settings(&build_settings, &toolchain, std::string()),

+ settings(&build_settings, std::string()),

+ toolchain(&settings, Label(SourceDir("//"), "tc")),

target(&settings, Label(SourceDir("//tools/gn/"), "name")) {

+ settings.set_toolchain_label(toolchain.label());

settings.set_target_os(Settings::WIN);

// Output going to "out/Debug".

« no previous file with comments | « tools/gn/ninja_helper.cc ('k') | tools/gn/ninja_script_target_writer.h » ('j') | no next file with comments »