Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: tools/gn/ninja_helper_unittest.cc

Issue 51693002: GN: toolchain threading cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_helper.cc ('k') | tools/gn/ninja_script_target_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_helper_unittest.cc
diff --git a/tools/gn/ninja_helper_unittest.cc b/tools/gn/ninja_helper_unittest.cc
index 6e3b25c07136307b7d427fd49a3b5a318bad007f..63082bc34e40550e905883a70d9589e05a58ba35 100644
--- a/tools/gn/ninja_helper_unittest.cc
+++ b/tools/gn/ninja_helper_unittest.cc
@@ -17,9 +17,10 @@ class HelperSetterUpper {
public:
HelperSetterUpper()
: build_settings(),
- toolchain(Label(SourceDir("//"), "tc")),
- settings(&build_settings, &toolchain, std::string()),
+ settings(&build_settings, std::string()),
+ toolchain(&settings, Label(SourceDir("//"), "tc")),
target(&settings, Label(SourceDir("//tools/gn/"), "name")) {
+ settings.set_toolchain_label(toolchain.label());
settings.set_target_os(Settings::WIN);
// Output going to "out/Debug".
« no previous file with comments | « tools/gn/ninja_helper.cc ('k') | tools/gn/ninja_script_target_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698