Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tools/gn/ninja_binary_target_writer_unittest.cc

Issue 51693002: GN: toolchain threading cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/ninja_copy_target_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer_unittest.cc
diff --git a/tools/gn/ninja_binary_target_writer_unittest.cc b/tools/gn/ninja_binary_target_writer_unittest.cc
index a7de4a118fa7e51bd05814ad135ff4c08b75f1f5..96a74480aa4654548688804b81c645bdbd11d331 100644
--- a/tools/gn/ninja_binary_target_writer_unittest.cc
+++ b/tools/gn/ninja_binary_target_writer_unittest.cc
@@ -22,7 +22,7 @@ TEST(NinjaBinaryTargetWriter, SourceSet) {
// Source set itself.
{
std::ostringstream out;
- NinjaBinaryTargetWriter writer(&target, out);
+ NinjaBinaryTargetWriter writer(&target, setup.toolchain(), out);
writer.Run();
// TODO(brettw) I think we'll need to worry about backslashes here
@@ -36,10 +36,10 @@ TEST(NinjaBinaryTargetWriter, SourceSet) {
"cflags_objc =\n"
"cflags_objcc =\n"
"\n"
- "build obj/foo/bar.input1.obj: tc_cxx ../../foo/input1.cc\n"
- "build obj/foo/bar.input2.obj: tc_cxx ../../foo/input2.cc\n"
+ "build obj/foo/bar.input1.obj: cxx ../../foo/input1.cc\n"
+ "build obj/foo/bar.input2.obj: cxx ../../foo/input2.cc\n"
"\n"
- "build obj/foo/bar.stamp: tc_stamp obj/foo/bar.input1.obj obj/foo/bar.input2.obj\n";
+ "build obj/foo/bar.stamp: stamp obj/foo/bar.input1.obj obj/foo/bar.input2.obj\n";
std::string out_str = out.str();
#if defined(OS_WIN)
std::replace(out_str.begin(), out_str.end(), '\\', '/');
@@ -55,7 +55,7 @@ TEST(NinjaBinaryTargetWriter, SourceSet) {
{
std::ostringstream out;
- NinjaBinaryTargetWriter writer(&shlib_target, out);
+ NinjaBinaryTargetWriter writer(&shlib_target, setup.toolchain(), out);
writer.Run();
// TODO(brettw) I think we'll need to worry about backslashes here
@@ -73,7 +73,7 @@ TEST(NinjaBinaryTargetWriter, SourceSet) {
"manifests = obj/foo/shlib.intermediate.manifest\n"
"ldflags = /MANIFEST /ManifestFile:obj/foo/shlib.intermediate.manifest\n"
"libs =\n"
- "build shlib.dll shlib.dll.lib: tc_solink obj/foo/bar.input1.obj obj/foo/bar.input2.obj\n"
+ "build shlib.dll shlib.dll.lib: solink obj/foo/bar.input1.obj obj/foo/bar.input2.obj\n"
" soname = shlib.dll\n"
" lib = shlib.dll\n"
" dll = shlib.dll\n"
« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/ninja_copy_target_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698