tools/gn/function_toolchain.cc - Issue 51693002: GN: toolchain threading cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/function_toolchain.cc

Issue 51693002: GN: toolchain threading cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/function_toolchain.cc

diff --git a/tools/gn/function_toolchain.cc b/tools/gn/function_toolchain.cc

index 933d55e9beed316fae019222a3db3702a97567dc..dde0306fb14cdc91922c1e534c010e5c47b7400b 100644

--- a/tools/gn/function_toolchain.cc

+++ b/tools/gn/function_toolchain.cc

@@ -102,7 +102,7 @@ Value RunToolchain(Scope* scope,

// This object will actually be copied into the one owned by the toolchain

// manager, but that has to be done in the lock.

- Toolchain toolchain(label);

+ Toolchain toolchain(scope->settings(), label);

Scope block_scope(scope);

block_scope.SetProperty(&kToolchainPropertyKey, &toolchain);

« no previous file with comments | « tools/gn/function_exec_script.cc ('k') | tools/gn/functions.cc » ('j') | no next file with comments »