Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: src/execution.h

Issue 516913003: Do not expose termination exceptions to the Exception API. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/elements.cc ('k') | src/execution.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/execution.h
diff --git a/src/execution.h b/src/execution.h
index 2a41bb8ba0d68a1fba217f5f3f301d9fa072294a..9af446b84b1caa432bcdcd1aea22f4a52a36a421 100644
--- a/src/execution.h
+++ b/src/execution.h
@@ -46,12 +46,12 @@ class Execution V8_FINAL : public AllStatic {
// any thrown exceptions. The return value is either the result of
// calling the function (if caught exception is false) or the exception
// that occurred (if caught exception is true).
- static MaybeHandle<Object> TryCall(
- Handle<JSFunction> func,
- Handle<Object> receiver,
- int argc,
- Handle<Object> argv[],
- Handle<Object>* exception_out = NULL);
+ // In the exception case, exception_out holds the caught exceptions, unless
+ // it is a termination exception.
+ static MaybeHandle<Object> TryCall(Handle<JSFunction> func,
+ Handle<Object> receiver, int argc,
+ Handle<Object> argv[],
+ MaybeHandle<Object>* exception_out = NULL);
// ECMA-262 9.3
MUST_USE_RESULT static MaybeHandle<Object> ToNumber(
« no previous file with comments | « src/elements.cc ('k') | src/execution.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698