Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: test/cctest/test-thread-termination.cc

Issue 516913003: Do not expose termination exceptions to the Exception API. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/scopes.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 CompileRun(terminate_and_loop); 452 CompileRun(terminate_and_loop);
453 CHECK(!try_catch.HasTerminated()); 453 CHECK(!try_catch.HasTerminated());
454 CHECK_EQ(2, callback_counter); 454 CHECK_EQ(2, callback_counter);
455 } 455 }
456 456
457 // Now the previously requested terminate execution interrupt should trigger. 457 // Now the previously requested terminate execution interrupt should trigger.
458 CompileRun("for (var i = 0; i < 10000; i++);"); 458 CompileRun("for (var i = 0; i < 10000; i++);");
459 CHECK(try_catch.HasTerminated()); 459 CHECK(try_catch.HasTerminated());
460 CHECK_EQ(2, callback_counter); 460 CHECK_EQ(2, callback_counter);
461 } 461 }
462
463
464 TEST(ErrorObjectAfterTermination) {
465 v8::Isolate* isolate = CcTest::isolate();
466 v8::HandleScope scope(isolate);
467 v8::Handle<v8::Context> context = v8::Context::New(CcTest::isolate());
468 v8::Context::Scope context_scope(context);
469 v8::V8::TerminateExecution(isolate);
470 v8::Local<v8::Value> error = v8::Exception::Error(v8_str("error"));
471 // TODO(yangguo): crbug/403509. Check for empty handle instead.
472 CHECK(error->IsUndefined());
473 }
OLDNEW
« no previous file with comments | « src/scopes.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698