Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 516883002: Disabling WebRTC call tests on Android ASAN. (Closed)

Created:
6 years, 3 months ago by phoglund_chromium
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disabling WebRTC call tests on Android ASAN. We are getting renderer crashes, disable until someone can investigate. BUG=392224, 408496 Committed: https://crrev.com/19191940bee0b6736c63c1b67560bd4976f5b75c Cr-Commit-Position: refs/heads/master@{#292611}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fixing disabled prefix to make friend decl work #

Patch Set 4 : Moving AEC tests to own file to make disables cleaner. #

Total comments: 2

Patch Set 5 : Fixing indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -231 lines) Patch
A content/browser/media/webrtc_aecdump_browsertest.cc View 1 2 3 1 chunk +212 lines, -0 lines 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 1 2 3 21 chunks +50 lines, -228 lines 0 comments Download
M content/browser/media/webrtc_internals.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/test/webrtc_content_browsertest_base.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/webrtc_content_browsertest_base.cc View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
phoglund_chromium
phoglund@chromium.org changed reviewers: + tommi@chromium.org
6 years, 3 months ago (2014-08-28 11:01:45 UTC) #1
phoglund_chromium
6 years, 3 months ago (2014-08-28 11:01:46 UTC) #2
tommi (sloooow) - chröme
lgtm
6 years, 3 months ago (2014-08-28 11:10:49 UTC) #3
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 3 months ago (2014-08-28 11:19:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/516883002/1
6 years, 3 months ago (2014-08-28 11:19:44 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 13:32:26 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 13:33:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/9982) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/9973) ios_rel_device_ninja ...
6 years, 3 months ago (2014-08-28 13:33:48 UTC) #8
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 3 months ago (2014-08-28 13:55:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/516883002/20001
6 years, 3 months ago (2014-08-28 13:55:31 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 14:50:19 UTC) #11
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 3 months ago (2014-08-28 15:04:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/516883002/40001
6 years, 3 months ago (2014-08-28 15:05:36 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 16:01:35 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 16:09:51 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/684)
6 years, 3 months ago (2014-08-28 16:09:52 UTC) #16
phoglund_chromium
tommi, please re-review. I ran into problems with friend declarations on the AEC tests. Since ...
6 years, 3 months ago (2014-08-29 08:06:30 UTC) #17
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/516883002/diff/60001/content/test/webrtc_content_browsertest_base.cc File content/test/webrtc_content_browsertest_base.cc (right): https://codereview.chromium.org/516883002/diff/60001/content/test/webrtc_content_browsertest_base.cc#newcode80 content/test/webrtc_content_browsertest_base.cc:80: // Always force iSAC 16K on Android for ...
6 years, 3 months ago (2014-08-29 08:11:52 UTC) #18
phoglund_chromium
Thanks! https://codereview.chromium.org/516883002/diff/60001/content/test/webrtc_content_browsertest_base.cc File content/test/webrtc_content_browsertest_base.cc (right): https://codereview.chromium.org/516883002/diff/60001/content/test/webrtc_content_browsertest_base.cc#newcode80 content/test/webrtc_content_browsertest_base.cc:80: // Always force iSAC 16K on Android for ...
6 years, 3 months ago (2014-08-29 08:22:35 UTC) #19
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 3 months ago (2014-08-29 08:22:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/516883002/80001
6 years, 3 months ago (2014-08-29 08:23:40 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-29 10:00:26 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-29 11:23:09 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/7162)
6 years, 3 months ago (2014-08-29 11:23:10 UTC) #24
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 3 months ago (2014-08-29 11:25:48 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/516883002/80001
6 years, 3 months ago (2014-08-29 11:26:42 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001) as b4bfa7e33ee72932dc4e74f062c7a31c43f85947
6 years, 3 months ago (2014-08-29 12:33:03 UTC) #27
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:07:51 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/19191940bee0b6736c63c1b67560bd4976f5b75c
Cr-Commit-Position: refs/heads/master@{#292611}

Powered by Google App Engine
This is Rietveld 408576698