Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 516873002: ServiceWorker: Queue tasks until the registration proxy becomes ready (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
Reviewers:
michaeln, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Queue tasks until the registration proxy becomes ready In [[Install]] algo. of the latest spec, register() resolves a promise with a registration object after the worker enters the installation process. This means the registration needs to set its .installing field before the register promise is resolved. But, before this patch, the registration cannot do so before resolving the register promise because its proxy is set when the registration is passed to the blink. This change makes the registration queue notifications of worker version and 'updatefound'. Once the proxy becomes ready, the registration handles them. Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#installation-algorithm BUG=399533, 406240 TEST=content_unittests --gtest_filter=ServiceWorker* TEST=run_webkit_tests.py http/tests/serviceworker Committed: https://crrev.com/850e832d6e311d3ceec0d6da592f52b112c84ec9 Cr-Commit-Position: refs/heads/master@{#292535}

Patch Set 1 : #

Patch Set 2 : fix compile errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -8 lines) Patch
M content/child/service_worker/web_service_worker_registration_impl.h View 1 2 chunks +21 lines, -0 lines 0 comments Download
M content/child/service_worker/web_service_worker_registration_impl.cc View 2 chunks +52 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nhiroki
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-28 11:41:45 UTC) #1
nhiroki
nhiroki@chromium.org changed reviewers: + horo@chromium.org, michaeln@chromium.org
6 years, 3 months ago (2014-08-28 11:45:15 UTC) #2
nhiroki
Ptal, thanks!
6 years, 3 months ago (2014-08-28 11:50:34 UTC) #3
nhiroki
fyi: I'm making another CL (https://codereview.chromium.org/517493002/) to update the installation process based on this CL. ...
6 years, 3 months ago (2014-08-28 11:59:34 UTC) #4
michaeln
lgtm
6 years, 3 months ago (2014-08-29 00:32:09 UTC) #5
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 3 months ago (2014-08-29 00:38:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/516873002/40001
6 years, 3 months ago (2014-08-29 00:39:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 555867abf933c40902978902e263d8926d828655
6 years, 3 months ago (2014-08-29 01:22:25 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:04:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/850e832d6e311d3ceec0d6da592f52b112c84ec9
Cr-Commit-Position: refs/heads/master@{#292535}

Powered by Google App Engine
This is Rietveld 408576698