Preliminary lowering of typed array loads in TF.

Preliminary lowering of typed array loads in TF.

R=titzer@chromium.org
TEST=cctest/test-run-properties/TypedArrayLoad

Committed: https://code.google.com/p/v8/source/detail?r=23492

[titzer, 2014-08-28 09:45:10]

https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-loweri...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:502: FieldAccess
JSTypedLowering::FieldAccessForElements() {
Let's pull these out to an AccessHelper class.

https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:566: element_access =
ElementAccessForTypedArray(kUntaggedBase, type, 0);
Maybe instead of passing the header size, you pass the externalness of the
elements kind to this method?

https://codereview.chromium.org/516853002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/516853002/diff/1/src/compiler/pipeline.cc#new...
src/compiler/pipeline.cc:252: PhaseStats lowering_stats(info(),
PhaseStats::CREATE_GRAPH,
PhaseStats should probably be OPTIMIZATION?

https://codereview.chromium.org/516853002/diff/1/src/compiler/pipeline.cc#new...
src/compiler/pipeline.cc:262: graph_reducer.AddReducer(&simple_reducer);
Can you leave a TODO for me here? I am not sure if running them all as one big
reducer pipeline is best. Have to think about it.

[Michael Starzinger, 2014-08-28 10:38:41]

Comments addressed. PTAL.

https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-loweri...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:502: FieldAccess
JSTypedLowering::FieldAccessForElements() {
On 2014/08/28 09:45:09, titzer wrote:
> Let's pull these out to an AccessHelper class.

Done. I called it just "Access" but I am happy to change the name if you want.

https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:566: element_access =
ElementAccessForTypedArray(kUntaggedBase, type, 0);
On 2014/08/28 09:45:10, titzer wrote:
> Maybe instead of passing the header size, you pass the externalness of the
> elements kind to this method?

Done.

https://codereview.chromium.org/516853002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/516853002/diff/1/src/compiler/pipeline.cc#new...
src/compiler/pipeline.cc:252: PhaseStats lowering_stats(info(),
PhaseStats::CREATE_GRAPH,
On 2014/08/28 09:45:10, titzer wrote:
> PhaseStats should probably be OPTIMIZATION?

Done.

https://codereview.chromium.org/516853002/diff/1/src/compiler/pipeline.cc#new...
src/compiler/pipeline.cc:262: graph_reducer.AddReducer(&simple_reducer);
On 2014/08/28 09:45:10, titzer wrote:
> Can you leave a TODO for me here? I am not sure if running them all as one big
> reducer pipeline is best. Have to think about it.

Done.

[titzer, 2014-08-28 11:09:03]

https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-loweri...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/516853002/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:502: FieldAccess
JSTypedLowering::FieldAccessForElements() {
On 2014/08/28 10:38:40, Michael Starzinger wrote:
> On 2014/08/28 09:45:09, titzer wrote:
> > Let's pull these out to an AccessHelper class.
> 
> Done. I called it just "Access" but I am happy to change the name if you want.

Maybe AccessBuilder...to prevent confusion between the actual FieldAccess and
ElementAccess instances and the thing that makes them....

[titzer, 2014-08-28 11:10:07]

https://codereview.chromium.org/516853002/diff/20001/src/compiler/simplified-...
File src/compiler/simplified-operator.h (right):

https://codereview.chromium.org/516853002/diff/20001/src/compiler/simplified-...
src/compiler/simplified-operator.h:99: class Access : public AllStatic {
Also, please put this in its own header file.

[Michael Starzinger, 2014-08-28 11:27:19]

Comments addressed. PTAL.

https://codereview.chromium.org/516853002/diff/20001/src/compiler/simplified-...
File src/compiler/simplified-operator.h (right):

https://codereview.chromium.org/516853002/diff/20001/src/compiler/simplified-...
src/compiler/simplified-operator.h:99: class Access : public AllStatic {
On 2014/08/28 11:10:07, titzer wrote:
> Also, please put this in its own header file.

Done.

[titzer, 2014-08-28 11:34:44]

lgtm

[Michael Starzinger, 2014-08-28 14:35:31]

Committed patchset #5 (id:80001) manually as 23492 (presubmit successful).