Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 516843005: Added missing test cases related to long pressing on input field. (Closed)

Created:
6 years, 3 months ago by AKVT
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added missing test cases related to long pressing on input field. IME Visibility status check test case is missing when we do long press on different kind of empty and non-empty input fields. This patch takes care of adding missing test cases for the same. BUG= Committed: https://crrev.com/17e569c9df725c47d9b7a164d13197a1511fbdf2 Cr-Commit-Position: refs/heads/master@{#292423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
AKVT
ajith.v@samsung.com changed reviewers: + aurimas@chromium.org, jdduke@chromium.org
6 years, 3 months ago (2014-08-28 15:11:04 UTC) #1
AKVT
@jdduke and aurimas PTAL this change.
6 years, 3 months ago (2014-08-28 15:11:04 UTC) #2
jdduke (slow)
On 2014/08/28 15:11:04, AKV wrote: > @jdduke and aurimas PTAL this change. If you plan ...
6 years, 3 months ago (2014-08-28 15:35:36 UTC) #3
AKVT
On 2014/08/28 15:35:36, jdduke wrote: > On 2014/08/28 15:11:04, AKV wrote: > > @jdduke and ...
6 years, 3 months ago (2014-08-28 16:30:31 UTC) #4
jdduke (slow)
lgtm
6 years, 3 months ago (2014-08-28 16:33:26 UTC) #5
AKVT
The CQ bit was checked by ajith.v@samsung.com
6 years, 3 months ago (2014-08-28 16:35:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajith.v@samsung.com/516843005/1
6 years, 3 months ago (2014-08-28 16:36:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9031278b24a8d0bbe19f03281114204875876c59
6 years, 3 months ago (2014-08-28 18:38:16 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17e569c9df725c47d9b7a164d13197a1511fbdf2
Cr-Commit-Position: refs/heads/master@{#292423}

Powered by Google App Engine
This is Rietveld 408576698