Source/core/events/Event.h - Issue 516843004: Fix crash when accessing Event::path().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/events/Event.h

Issue 516843004: Fix crash when accessing Event::path(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review feedback. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/dom/crash-on-querying-event-path-expected.txt ('k') | Source/core/events/Event.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2001 Peter Kelly (pmk@post.com)	2 * Copyright (C) 2001 Peter Kelly (pmk@post.com)

3 * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)	3 * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)

4 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)	4 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)

5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed.	5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 186 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
197 bool m_canBubble;	197 bool m_canBubble;

198 bool m_cancelable;	198 bool m_cancelable;

199	199

200 bool m_propagationStopped;	200 bool m_propagationStopped;

201 bool m_immediatePropagationStopped;	201 bool m_immediatePropagationStopped;

202 bool m_defaultPrevented;	202 bool m_defaultPrevented;

203 bool m_defaultHandled;	203 bool m_defaultHandled;

204 bool m_cancelBubble;	204 bool m_cancelBubble;

205	205

206 unsigned short m_eventPhase;	206 unsigned short m_eventPhase;

207 RawPtrWillBeMember<EventTarget> m_currentTarget;	207 RefPtrWillBeMember<EventTarget> m_currentTarget;

208 RefPtrWillBeMember<EventTarget> m_target;	208 RefPtrWillBeMember<EventTarget> m_target;

209 DOMTimeStamp m_createTime;	209 DOMTimeStamp m_createTime;

210 RefPtrWillBeMember<Event> m_underlyingEvent;	210 RefPtrWillBeMember<Event> m_underlyingEvent;

211 OwnPtrWillBeMember<EventPath> m_eventPath;	211 OwnPtrWillBeMember<EventPath> m_eventPath;

212 };	212 };

213	213

214 #define DEFINE_EVENT_TYPE_CASTS(typeName) \	214 #define DEFINE_EVENT_TYPE_CASTS(typeName) \

215 DEFINE_TYPE_CASTS(typeName, Event, event, event->is##typeName(), event.is##t ypeName())	215 DEFINE_TYPE_CASTS(typeName, Event, event, event->is##typeName(), event.is##t ypeName())

216	216

217 } // namespace blink	217 } // namespace blink

218	218

219 #endif // Event_h	219 #endif // Event_h

OLD	NEW