LayoutTests/http/tests/dom/crash-on-querying-event-path.html - Issue 516843004: Fix crash when accessing Event::path().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/dom/crash-on-querying-event-path.html

Issue 516843004: Fix crash when accessing Event::path(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review feedback. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="/js-test-resources/js-test.js"></script>

	4 </head>

	5 <body>

	6 <script>

	7 var jsTestIsAsync = true;

	8 description('This is a regression test for crbug.com/400476. It should not crash and then brag about it.')

	9

	10 var root = document.documentElement;

	11 var iframe = root.ownerDocument.createElement('iframe');

	12 iframe.onload = iframeOnload;

	13 root.appendChild(iframe);

	14

	15 function iframeOnload() {

	16 var defaultView = iframe.contentDocument.defaultView;

	17 defaultView.onpageshow = onPageShow;

	18 iframe.src = null;

	19 window.setTimeout(nextIframeLoaded, 100);

	20 }

	21

	22 function onPageShow() {

	23 eventObj = arguments[0];

	24 }

	25

	26 function nextIframeLoaded() {

	27 // Access of eventObj.path caused the crash.

	28 // The test is somewhat flaky, in that the test may pass as correct

	29 // despite the bug being the code. The exact conditions

	30 // are unclear, but 1, asan helps detect the crash and 2, the

	31 // preceeding gc()s increase the likelihood of it occurring.

	32 gc();

	33 gc();

	34 gc();

	35 gc();

	36 gc();

	37 var path = eventObj.path;

	38 debug(path);

	39

	40 testPassed('totally did not crash.');

	41 finishJSTest();

	42 }

	43 </script>

	44 </body>

	45 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/http/tests/dom/crash-on-querying-event-path-expected.txt » ('j') | no next file with comments »