LayoutTests/fast/dom/event-400476.html - Issue 516843004: Fix crash when accessing Event::path().

Side by Side Diff: LayoutTests/fast/dom/event-400476.html

Issue 516843004: Fix crash when accessing Event::path(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added regression test. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	haraken 2014/08/28 17:32:39 Make the test name more descriptive. Make the test name more descriptive. vogelheim 2014/08/29 15:20:52 Done. Show quoted text On 2014/08/28 17:32:39, haraken wrote: > > Make the test name more descriptive. Done.
	2 <head>

	3 <script>
	haraken 2014/08/28 17:32:39 You can include resources/js-test.js, which has a You can include resources/js-test.js, which has a bunch of utility functions for testing. vogelheim 2014/08/29 15:20:52 Done. Show quoted text On 2014/08/28 17:32:39, haraken wrote: > > You can include resources/js-test.js, which has a bunch of utility functions for > testing. > Done.
	4 if (window.testRunner) {

	5 testRunner.dumpAsText();
	haraken 2014/08/28 17:32:39 Once you include js-test.js, testRunner.dumpAsText Once you include js-test.js, testRunner.dumpAsText() won't be needed. vogelheim 2014/08/29 15:20:52 Done. Show quoted text On 2014/08/28 17:32:39, haraken wrote: > > Once you include js-test.js, testRunner.dumpAsText() won't be needed. Done.
	6 testRunner.waitUntilDone();

	7 }

	8

	9 function test() {

	10 root=document.documentElement;
	haraken 2014/08/28 17:32:38 Use 4-indent space. Use 4-indent space. haraken 2014/08/28 17:32:39 Add 'var' to local variables. Add 'var' to local variables. vogelheim 2014/08/29 15:20:52 Done. Show quoted text On 2014/08/28 17:32:38, haraken wrote: > > Use 4-indent space. Done. vogelheim 2014/08/29 15:20:52 Done. (Here & elsewhere.) Show quoted text On 2014/08/28 17:32:39, haraken wrote: > > Add 'var' to local variables. Done. (Here & elsewhere.)
	11 iframe=root.ownerDocument.createElementNS('http://www.w3.org/1999/xhtml','ifra me');
	haraken 2014/08/28 17:32:38 Add one space around '='. Add one space around '='. vogelheim 2014/08/29 15:20:52 Done. Show quoted text On 2014/08/28 17:32:38, haraken wrote: > > Add one space around '='. Done.
	12 iframe.onload=iframe_onload_fn;
	haraken 2014/08/28 17:32:39 iframe_onload_fn => iframeLoaded Use camelCase na iframe_onload_fn => iframeLoaded Use camelCase names. vogelheim 2014/08/29 15:20:52 Done. Show quoted text On 2014/08/28 17:32:39, haraken wrote: > > iframe_onload_fn => iframeLoaded > > Use camelCase names. Done.
	13 root.appendChild(iframe);

	14 }

	15 function iframe_onload_fn() {
	haraken 2014/08/28 17:32:39 Add one empty line between functions. Add one empty line between functions. vogelheim 2014/08/29 15:20:52 Done. Show quoted text On 2014/08/28 17:32:39, haraken wrote: > > Add one empty line between functions. Done.
	16 defaultView=iframe.contentDocument.defaultView;

	17 defaultView.onpageshow=onPageShow;

	18 iframe.src=null;

	19 window.setTimeout(triggerFn, 100);
	haraken 2014/08/28 17:32:38 triggerFn => nextIframeLoaded Use a more descript triggerFn => nextIframeLoaded Use a more descriptive name. vogelheim 2014/08/29 15:20:52 Done. Show quoted text On 2014/08/28 17:32:38, haraken wrote: > > triggerFn => nextIframeLoaded > > Use a more descriptive name. Done.
	20 }

	21 function onPageShow() {

	22 problem_ref=arguments[0];

	23 }

	24 function triggerFn() {

	25 document.write('<p>' + problem_ref.path + '</p>');
	haraken 2014/08/28 17:32:39 Don't use document.write unless it's really needed Don't use document.write unless it's really needed. Here you can use shouldBe('event.path', ...) vogelheim 2014/08/29 15:20:52 Done. Show quoted text On 2014/08/28 17:32:39, haraken wrote: > > Don't use document.write unless it's really needed. Here you can use > shouldBe('event.path', ...) Done.
	26 document.write('<p>PASS: totally did not crash.</p>');

	27 testRunner.notifyDone();

	28 }

	29 </script>
	haraken 2014/08/28 17:32:39 Put this <script> tag in <body>. Then you won't ne Put this <script> tag in <body>. Then you won't need the test() function. vogelheim 2014/08/29 15:20:52 Done. (Well, it's still in the header, but the onl Show quoted text On 2014/08/28 17:32:39, haraken wrote: > > Put this <script> tag in <body>. Then you won't need the test() function. Done. (Well, it's still in the header, but the onload=... is gone.)
	30 </head>

	31 <body onload="test();">

	32 <p>This is a regression test for crbug.com/400476. It should not crash and then brag about it.</p>

	33 </body>

	34 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/event-400476-expected.txt » ('j') | no next file with comments »