Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 516833002: Removed NativeMetafile and PreviewMetafile typedef as it's always PdfMetafileSkia. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@no_pdf
Project:
chromium
Visibility:
Public.

Description

Removed NativeMetafile and PreviewMetafile typedef as it's always PdfMetafileSkia. BUG=170859 TBR=sgurun, yzshen Committed: https://crrev.com/fdd3212ca1a30226a09f5505a4331afcc0d0e8d2 Cr-Commit-Position: refs/heads/master@{#292561}

Patch Set 1 #

Patch Set 2 : Thu Aug 28 01:51:13 PDT 2014 #

Patch Set 3 : Thu Aug 28 01:53:23 PDT 2014 #

Patch Set 4 : Thu Aug 28 01:56:49 PDT 2014 #

Patch Set 5 : Thu Aug 28 02:43:23 PDT 2014 #

Total comments: 3

Patch Set 6 : Thu Aug 28 13:14:05 PDT 2014 #

Patch Set 7 : Thu Aug 28 13:23:31 PDT 2014 #

Patch Set 8 : Thu Aug 28 17:07:38 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -68 lines) Patch
M android_webview/common/print_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/print_web_view_helper.h View 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/renderer/print_web_view_helper.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M android_webview/renderer/print_web_view_helper_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/print_messages.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/printing/mock_printer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 2 3 4 5 6 7 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_linux.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_mac.mm View 1 2 3 4 5 6 7 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_pdf_win.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 2 3 4 5 6 2 chunks +0 lines, -7 lines 0 comments Download
M printing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M printing/image.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D printing/metafile_impl.h View 1 2 3 4 5 1 chunk +0 lines, -18 lines 0 comments Download
M printing/printing.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M printing/printing_context_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + thestig@chromium.org
6 years, 3 months ago (2014-08-28 08:57:55 UTC) #1
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + jschuh@chromium.org
6 years, 3 months ago (2014-08-28 17:55:43 UTC) #2
Vitaly Buka (NO REVIEWS)
+jschuh for chrome/common/print_messages.h Only comment in the code was changed.
6 years, 3 months ago (2014-08-28 17:55:44 UTC) #3
Lei Zhang
Can we get rid of WIN_PDF_METAFILE_FOR_PRINTING yet? If so, I'd do that first. https://codereview.chromium.org/516833002/diff/80001/chrome/browser/printing/print_view_manager_base.cc File ...
6 years, 3 months ago (2014-08-28 18:11:24 UTC) #4
Vitaly Buka (NO REVIEWS)
On 2014/08/28 18:11:24, Lei Zhang wrote: > Can we get rid of WIN_PDF_METAFILE_FOR_PRINTING yet? If ...
6 years, 3 months ago (2014-08-28 18:27:31 UTC) #5
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/516833002/diff/80001/chrome/browser/printing/print_view_manager_base.cc File chrome/browser/printing/print_view_manager_base.cc (right): https://codereview.chromium.org/516833002/diff/80001/chrome/browser/printing/print_view_manager_base.cc#newcode207 chrome/browser/printing/print_view_manager_base.cc:207: scoped_ptr<PdfMetafileSkia> raster_metafile( It would go away with WIN_PDF_METAFILE_FOR_PRINTING. I'll ...
6 years, 3 months ago (2014-08-28 18:28:49 UTC) #6
jschuh
On 2014/08/28 18:11:24, Lei Zhang wrote: > Can we get rid of WIN_PDF_METAFILE_FOR_PRINTING yet? If ...
6 years, 3 months ago (2014-08-28 18:31:34 UTC) #7
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + sgurun@google.com
6 years, 3 months ago (2014-08-28 20:18:46 UTC) #8
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/516833002/diff/80001/chrome/browser/printing/print_view_manager_base.cc File chrome/browser/printing/print_view_manager_base.cc (right): https://codereview.chromium.org/516833002/diff/80001/chrome/browser/printing/print_view_manager_base.cc#newcode207 chrome/browser/printing/print_view_manager_base.cc:207: scoped_ptr<PdfMetafileSkia> raster_metafile( On 2014/08/28 18:11:23, Lei Zhang wrote: > ...
6 years, 3 months ago (2014-08-28 20:18:46 UTC) #9
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + yzshen@google.com
6 years, 3 months ago (2014-08-28 20:19:30 UTC) #10
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + sgurun@chromium.org - sgurun@google.com
6 years, 3 months ago (2014-08-28 20:22:24 UTC) #11
Lei Zhang
lgtm
6 years, 3 months ago (2014-08-28 20:27:08 UTC) #12
sgurun-gerrit only
On 2014/08/28 20:27:08, Lei Zhang wrote: > lgtm aw lgtm
6 years, 3 months ago (2014-08-28 20:56:58 UTC) #13
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + yzshen@chromium.org - yzshen@google.com
6 years, 3 months ago (2014-08-28 23:15:03 UTC) #14
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-28 23:43:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/516833002/140001
6 years, 3 months ago (2014-08-28 23:45:14 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 23:55:59 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 23:58:00 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47895) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/10249) ios_rel_device ...
6 years, 3 months ago (2014-08-28 23:58:01 UTC) #19
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-29 00:05:01 UTC) #20
Vitaly Buka (NO REVIEWS)
Patchset #7 (id:120001) has been deleted
6 years, 3 months ago (2014-08-29 00:06:22 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/516833002/140001
6 years, 3 months ago (2014-08-29 00:06:32 UTC) #22
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-29 00:08:42 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/516833002/160001
6 years, 3 months ago (2014-08-29 00:10:09 UTC) #24
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-29 02:06:18 UTC) #25
commit-bot: I haz the power
Committed patchset #8 (id:160001) as 3ad2d64bc4048c7dd68bee707ba1358c677fe34d
6 years, 3 months ago (2014-08-29 03:12:22 UTC) #26
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:05:53 UTC) #27
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/fdd3212ca1a30226a09f5505a4331afcc0d0e8d2
Cr-Commit-Position: refs/heads/master@{#292561}

Powered by Google App Engine
This is Rietveld 408576698