[Net] Assert that URLRequests with LOAD_IGNORE_LIMITS have MAXIMUM_PRIORITY

content/browser/loader/resource_scheduler.cc

Index: content/browser/loader/resource_scheduler.cc
diff --git a/content/browser/loader/resource_scheduler.cc b/content/browser/loader/resource_scheduler.cc
index d458936ecf1e29110a8a935fbcbcca3ad155f5a6..5cd9cd2c9edf6b9b144a4fc8c9987ae1ba605627 100644
--- a/content/browser/loader/resource_scheduler.cc
+++ b/content/browser/loader/resource_scheduler.cc
@@ -273,6 +273,12 @@ void ResourceScheduler::StartRequest(ScheduledResourceRequest* request,
 
 void ResourceScheduler::ReprioritizeRequest(ScheduledResourceRequest* request,
                                             net::RequestPriority new_priority) {
+  if ((request->url_request()->load_flags() & net::LOAD_IGNORE_LIMITS) != 0) {

[mmenke, 2013/11/01 19:06:39]

optional nit:  I think !(request->url_request()->load_flags() &
net::LOAD_IGNORE_LIMITS) is a little more intuitive.

[akalin, 2013/11/01 23:15:51]

Done.

+    // We should not be re-prioritizing requests with the
+    // IGNORE_LIMITS flag.
+    NOTREACHED();
+    return;
+  }
   net::RequestPriority old_priority = request->url_request()->priority();
   DCHECK_NE(new_priority, old_priority);
   request->url_request()->SetPriority(new_priority);
@@ -290,7 +296,8 @@ void ResourceScheduler::ReprioritizeRequest(ScheduledResourceRequest* request,
   }
 
   client->pending_requests.Erase(request);
-  client->pending_requests.Insert(request, request->url_request()->priority());
+  client->pending_requests.Insert(request,
+                                  request->url_request()->priority());
 
   if (new_priority > old_priority) {
     // Check if this request is now able to load at its new priority.