Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: net/url_request/url_request.h

Issue 51683002: [Net] Assert that URLRequests with LOAD_IGNORE_LIMITS have MAXIMUM_PRIORITY (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request.h
diff --git a/net/url_request/url_request.h b/net/url_request/url_request.h
index 1145f6343aeb513ea1e3b6aeb1e9ecd1dc39a425..e3e5ada8419a2acbce5d875a2bd77d156949d2c6 100644
--- a/net/url_request/url_request.h
+++ b/net/url_request/url_request.h
@@ -556,7 +556,11 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
// Access the LOAD_* flags modifying this request (see load_flags.h).
int load_flags() const { return load_flags_; }
- void set_load_flags(int flags) { load_flags_ = flags; }
+
+ // The new flags must not change the IGNORE_LIMITS flag (which
+ // affects the result of GetPriority()) if called after Start() is
+ // called.
+ void SetLoadFlags(int flags);
// Returns true if the request is "pending" (i.e., if Start() has been called,
// and the response has not yet been called).
@@ -654,8 +658,10 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
// Returns the expected content size if available
int64 GetExpectedContentSize() const;
- // Returns the priority level for this request.
- RequestPriority priority() const { return priority_; }
+ // Returns the priority level for this request. Objects like
+ // ClientSocketPool use this to determine which URLRequest to
+ // allocate sockets to first.
+ RequestPriority GetPriority() const;
// Sets the priority level for this request and any related jobs.
void SetPriority(RequestPriority priority);
@@ -833,9 +839,10 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
// first transaction in a request involving redirects.
UploadProgress final_upload_progress_;
- // The priority level for this request. Objects like ClientSocketPool use
- // this to determine which URLRequest to allocate sockets to first.
- RequestPriority priority_;
+ // The base priority level for this request before load flags are
+ // taken into account. Should not be used directly; GetPriority()
+ // should be used instead.
+ RequestPriority base_priority_;
// TODO(battre): The only consumer of the identifier_ is currently the
// web request API. We need to match identifiers of requests between the

Powered by Google App Engine
This is Rietveld 408576698