Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 516823002: Removed print_web_view_helper_win.cc (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removed print_web_view_helper_win.cc Removed win_pdf_metafile_for_printing gyp option. Removed WIN_PDF_METAFILE_FOR_PRINTING define. BUG=170859 TBR=yzshen Committed: https://crrev.com/36259ca6a4aa40fa18c2ccbffa4e6b3a8b711868 Cr-Commit-Position: refs/heads/master@{#292501}

Patch Set 1 #

Patch Set 2 : Thu Aug 28 01:24:26 PDT 2014 #

Patch Set 3 : Thu Aug 28 01:25:20 PDT 2014 #

Patch Set 4 : Thu Aug 28 01:30:54 PDT 2014 #

Total comments: 2

Patch Set 5 : Thu Aug 28 13:09:51 PDT 2014 #

Patch Set 6 : Thu Aug 28 14:04:52 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -379 lines) Patch
M build/common.gypi View 1 2 3 4 3 chunks +0 lines, -7 lines 0 comments Download
M build/config/BUILD.gn View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager_base.h View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 1 2 3 4 5 9 chunks +13 lines, -42 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 2 3 4 2 chunks +1 line, -9 lines 0 comments Download
M chrome/common/chrome_utility_printing_messages.h View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/common/print_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.h View 3 chunks +3 lines, -12 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
D chrome/renderer/printing/print_web_view_helper_win.cc View 1 chunk +0 lines, -249 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/printing_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/utility/printing_handler.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M printing/metafile_impl.h View 1 2 3 4 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + jschuh@chromium.org, scottmg@chromium.org
6 years, 3 months ago (2014-08-28 08:33:49 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-08-28 08:33:49 UTC) #2
jschuh
ipc security lgtm (notes: message removal and refactoring)
6 years, 3 months ago (2014-08-28 16:49:12 UTC) #3
scottmg
LGTM, thanks!
6 years, 3 months ago (2014-08-28 18:28:25 UTC) #4
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + thestig@chromium.org
6 years, 3 months ago (2014-08-28 18:29:30 UTC) #5
Vitaly Buka (NO REVIEWS)
+thestig
6 years, 3 months ago (2014-08-28 18:29:30 UTC) #6
Lei Zhang
lgtm https://codereview.chromium.org/516823002/diff/60001/printing/metafile_impl.h File printing/metafile_impl.h (right): https://codereview.chromium.org/516823002/diff/60001/printing/metafile_impl.h#newcode11 printing/metafile_impl.h:11: #include "printing/emf_win.h" also remove
6 years, 3 months ago (2014-08-28 18:36:17 UTC) #7
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/516823002/diff/60001/printing/metafile_impl.h File printing/metafile_impl.h (right): https://codereview.chromium.org/516823002/diff/60001/printing/metafile_impl.h#newcode11 printing/metafile_impl.h:11: #include "printing/emf_win.h" On 2014/08/28 18:36:16, Lei Zhang wrote: > ...
6 years, 3 months ago (2014-08-28 20:10:27 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-28 20:11:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/516823002/80001
6 years, 3 months ago (2014-08-28 20:12:24 UTC) #10
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + yzshen@chromium.org
6 years, 3 months ago (2014-08-28 20:26:49 UTC) #11
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-28 20:26:52 UTC) #12
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-28 20:27:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/516823002/80001
6 years, 3 months ago (2014-08-28 20:27:07 UTC) #14
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-28 21:05:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/516823002/100001
6 years, 3 months ago (2014-08-28 21:05:41 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 84aa254019f8b55b04b31c8a8cff0646e4270c2d
6 years, 3 months ago (2014-08-28 23:42:38 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:40 UTC) #18
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/36259ca6a4aa40fa18c2ccbffa4e6b3a8b711868
Cr-Commit-Position: refs/heads/master@{#292501}

Powered by Google App Engine
This is Rietveld 408576698