Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 516743002: Force scales 125% and lower down to 100% (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/9e8cd3d9ee725aab2bea7a3b89e64c9afc10b975 Cr-Commit-Position: refs/heads/master@{#292494}

Patch Set 1 #

Total comments: 1

Patch Set 2 : move to getdpiscale #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/gfx/win/dpi.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scottmg
6 years, 3 months ago (2014-08-28 01:37:23 UTC) #1
ananta
On 2014/08/28 01:37:23, scottmg wrote: GetDPIScale in ui/gfx/win/dpi.cc seems like a better place to do ...
6 years, 3 months ago (2014-08-28 01:52:05 UTC) #2
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/516743002/diff/1/chrome/app/chrome_exe_main_win.cc File chrome/app/chrome_exe_main_win.cc (right): https://codereview.chromium.org/516743002/diff/1/chrome/app/chrome_exe_main_win.cc#newcode112 chrome/app/chrome_exe_main_win.cc:112: "force-device-scale-factor", L"1"); kForceDeviceScaleFactor ?
6 years, 3 months ago (2014-08-28 20:59:38 UTC) #3
scottmg
scottmg@chromium.org changed reviewers: + sky@chromium.org - shrikant@chromium.org
6 years, 3 months ago (2014-08-28 22:50:58 UTC) #4
scottmg
6 years, 3 months ago (2014-08-28 23:06:27 UTC) #5
sky
I verified this makes us look exactly as we use to, both with and without ...
6 years, 3 months ago (2014-08-28 23:23:29 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm
6 years, 3 months ago (2014-08-28 23:28:27 UTC) #7
scottmg
https://codereview.chromium.org/516743002/diff/40001/ui/gfx/win/dpi.cc File ui/gfx/win/dpi.cc (right): https://codereview.chromium.org/516743002/diff/40001/ui/gfx/win/dpi.cc#newcode137 ui/gfx/win/dpi.cc:137: if (GetDPI().width() <= 120) { On 2014/08/28 23:23:29, sky ...
6 years, 3 months ago (2014-08-28 23:29:22 UTC) #8
scottmg
Committed patchset #4 (id:60001) to pending queue manually as fe6bf0d (presubmit successful).
6 years, 3 months ago (2014-08-28 23:32:13 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:22 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9e8cd3d9ee725aab2bea7a3b89e64c9afc10b975
Cr-Commit-Position: refs/heads/master@{#292494}

Powered by Google App Engine
This is Rietveld 408576698