Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 516723004: Update host compiler version info for android webview. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update host compiler version info for android webview. The android webview build now uses clang when building for host; update the gyp variables appropriately to make sure we use reasonable compiler flags. BUG=377684 Committed: https://crrev.com/ed51a58fb7366557e5dc3b874aa9821d8c5d5343 Cr-Commit-Position: refs/heads/master@{#292418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M build/common.gypi View 2 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Torne
torne@chromium.org changed reviewers: + primiano@chromium.org, thakis@chromium.org
6 years, 3 months ago (2014-08-28 14:18:16 UTC) #1
Torne
Hi Nico, Primiano, This looks like the right update to the gyp file to get ...
6 years, 3 months ago (2014-08-28 14:18:16 UTC) #2
Nico
lgtm
6 years, 3 months ago (2014-08-28 14:24:45 UTC) #3
Torne
The CQ bit was checked by torne@chromium.org
6 years, 3 months ago (2014-08-28 15:29:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/516723004/1
6 years, 3 months ago (2014-08-28 15:30:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 10bc5cb4126dccb95c344d33c841d40677547dfb
6 years, 3 months ago (2014-08-28 18:28:33 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed51a58fb7366557e5dc3b874aa9821d8c5d5343
Cr-Commit-Position: refs/heads/master@{#292418}

Powered by Google App Engine
This is Rietveld 408576698