Issue 516703005: Remove built-in component and test targets from GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 516703005: Remove built-in component and test targets from GN. (Closed)

Created:
6 years, 3 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Committed: https://crrev.com/60a5bf4a8a5d1a2dad8e7a67f81e72756e886266 Cr-Commit-Position: refs/heads/master@{#292500}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+149 lines, -159 lines)			Patch
M	build/config/BUILDCONFIG.gn	View	3 chunks	+149 lines, -25 lines	0 comments	Download
M	tools/gn/functions.h	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	tools/gn/functions.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/gn/functions_target.cc	View	2 chunks	+0 lines, -90 lines	0 comments	Download
M	tools/gn/variables.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tools/gn/variables.cc	View	2 chunks	+0 lines, -20 lines	0 comments	Download

Total messages: 5 (0 generated)

brettw

brettw@chromium.org changed reviewers: + hclam@chromium.org

6 years, 3 months ago (2014-08-28 20:16:27 UTC) #1

brettw

Committed patchset #1 (id:1) to pending queue manually as 014f773 (presubmit successful).

6 years, 3 months ago (2014-08-28 23:35:46 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:03:38 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/60a5bf4a8a5d1a2dad8e7a67f81e72756e886266
Cr-Commit-Position: refs/heads/master@{#292500}