Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2797)

Unified Diff: chrome/android/java/res/layout/website_settings.xml

Issue 516703002: Replaced the current WebsiteSettings dialog with a new PageInfo dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed "is_android" guard on permission strings. Could have #defined out the function that uses th… Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/website_settings.xml
diff --git a/chrome/android/java/res/layout/website_settings.xml b/chrome/android/java/res/layout/website_settings.xml
index cb614cacab3d1208f441beebeb24263f3b4a634d..59aede5bddd4cb2cba5fce4b5cadaf69e610938d 100644
--- a/chrome/android/java/res/layout/website_settings.xml
+++ b/chrome/android/java/res/layout/website_settings.xml
@@ -8,31 +8,26 @@
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent"
- android:orientation="horizontal" >
+ android:background="@color/website_settings_popup_background"
+ android:orientation="vertical"
+ android:paddingBottom="@dimen/website_settings_margin_bottom"
+ android:paddingEnd="@dimen/website_settings_margin_sides"
+ android:paddingStart="@dimen/website_settings_margin_sides"
+ android:paddingTop="@dimen/website_settings_margin_top" >
- <ImageView
- android:id="@+id/website_settings_icon"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content" />
-
- <LinearLayout
- android:id="@+id/website_settings_text_layout"
- android:layout_width="wrap_content"
+ <TextView
+ android:id="@+id/website_settings_url"
+ android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:orientation="vertical"
- android:paddingStart="@dimen/certificate_viewer_padding_thin" >
-
- <TextView
- android:id="@+id/website_settings_headline"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:paddingBottom="@dimen/certificate_viewer_padding_thin"
- android:textStyle="bold" />
+ android:paddingBottom="@dimen/website_settings_margin_below_url"
+ android:textColor="@color/website_settings_popup_url"
+ android:textSize="@dimen/website_settings_url_title_size" />
- <TextView
- android:id="@+id/website_settings_description"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content" />
- </LinearLayout>
+ <TextView
+ android:id="@+id/website_settings_permission_message"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:textColor="@color/website_settings_popup_text"
+ android:textSize="@dimen/website_settings_url_description_size" />
</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698