chrome/chrome.gyp - Issue 516703002: Replaced the current WebsiteSettings dialog with a new PageInfo dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome.gyp

Issue 516703002: Replaced the current WebsiteSettings dialog with a new PageInfo dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small review feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/website_settings/website_settings_ui.cc ('K') | « chrome/browser/ui/website_settings/website_settings_ui.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome.gyp

diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp

index edd094e92819e0088eb798929e4ff7bf4aaf3f88..392698b50d3b977024c6b8b1af49bb997649f998 100644

--- a/chrome/chrome.gyp

+++ b/chrome/chrome.gyp

@@ -585,6 +585,7 @@

'chrome_resources.gyp:chrome_strings',

'chrome_strings_grd',

'profile_account_management_metrics_java',

+ 'page_info_connection_type_java',

'profile_sync_service_model_type_selection_java',

'resource_id_java',

'toolbar_model_security_levels_java',

@@ -628,6 +629,14 @@

'../build/java_strings_grd.gypi',

+ {

+ 'target_name': 'page_info_connection_type_java',

+ 'type': 'none',

+ 'variables': {

+ 'source_file': 'browser/ui/android/website_settings_popup_android.h',

+ },

+ 'includes': [ '../build/android/java_cpp_enum.gypi' ],

+ },

], # 'targets'

'includes': [

'chrome_android.gypi',