android_webview/java_library_common.mk - Issue 516703002: Replaced the current WebsiteSettings dialog with a new PageInfo dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java_library_common.mk

Issue 516703002: Replaced the current WebsiteSettings dialog with a new PageInfo dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small androidwebview fix Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/libwebviewchromium.gypi » ('j') | content/public/android/java/src/org/chromium/content/common/ContentSwitches.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java_library_common.mk

diff --git a/android_webview/java_library_common.mk b/android_webview/java_library_common.mk

index 640369135a9f5be8dcbafdc92a74f66a2750c7b6..0e6098cb05d57b1f627307bdead3f57744e08ccb 100644

--- a/android_webview/java_library_common.mk

+++ b/android_webview/java_library_common.mk

@@ -38,10 +38,13 @@ LOCAL_SRC_FILES += \

# Java files generated from .template rules. This list should match list of java dependencies in

# android_webview/android_webview.gyp

+# TODO(sashab, mkosiba): Is the list of Java dependencies really in android_webview.gyp and not

+# libwebviewchromium.gypi?

LOCAL_GENERATED_SOURCES := \

$(call intermediates-dir-for,GYP,shared)/enums/bitmap_format_java/org/chromium/ui/gfx/BitmapFormat.java \

$(call intermediates-dir-for,GYP,shared)/enums/cert_verify_status_android_java/org/chromium/net/CertVerifyStatusAndroid.java \

$(call intermediates-dir-for,GYP,shared)/enums/certificate_mime_types_java/org/chromium/net/CertificateMimeType.java \

+$(call intermediates-dir-for,GYP,shared)/enums/page_info_connection_type/org/chromium/chrome/browser/PageInfoConnectionType.java \

benm (inactive) 2014/10/06 09:04:07 Hold up, sorry I didn't notice this before. WebVie

sashab 2014/10/06 23:11:54 No, Android Webview doesn't need PageInfoConnectio

$(call intermediates-dir-for,GYP,shared)/enums/private_key_types_java/org/chromium/net/PrivateKeyType.java \

$(call intermediates-dir-for,GYP,shared)/enums/window_open_disposition_java/org/chromium/ui/WindowOpenDisposition.java \

$(call intermediates-dir-for,GYP,shared)/templates/org/chromium/base/ApplicationState.java \

« no previous file with comments | « no previous file | android_webview/libwebviewchromium.gypi » ('j') | content/public/android/java/src/org/chromium/content/common/ContentSwitches.java » ('J')