Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 516693002: Revert of Initialize the now_funciton to the HighResNowWrapper in case High Res is supported (Closed)

Created:
6 years, 3 months ago by fmeawad
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, tonyg, brianderson, cpu_(ooo_6.6-7.5)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Initialize the now_funciton to the HighResNowWrapper in case High Res is supported (patchset #7 of https://codereview.chromium.org/446203002/) Reason for revert: It causes a Canary crash https://code.google.com/p/chromium/issues/detail?id=408354 The added static initializer causes a crash in libpeerconnetion used by WebRTC Fix to reland: remove static initializer. Original issue's description: > We have noticed a clock shift when QPC was deployed. It shows as a regression on the perf bots > https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928 > > It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC). > This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper. > > By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize. > > BUG=158234 > > Committed: https://chromium.googlesource.com/chromium/src/+/10c40c221c314e41add0a5b4df1ee7467681a430 TBR=jar@chromium.org,willchan@chromium.org,maruel@chromium.org,thakis@chromium.org,jam@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=158234 Committed: https://crrev.com/3a38fb5efd526a2278ab3b577c8c7881a3ad4d20 Cr-Commit-Position: refs/heads/master@{#292288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -20 lines) Patch
M base/test/test_suite.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/time/time.h View 1 chunk +8 lines, -0 lines 0 comments Download
M base/time/time_win.cc View 5 chunks +30 lines, -20 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/content_main_runner.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fmeawad
Created Revert of Initialize the now_funciton to the HighResNowWrapper in case High Res is supported
6 years, 3 months ago (2014-08-28 00:00:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmeawad@chromium.org/516693002/1
6 years, 3 months ago (2014-08-28 00:07:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9705ba25791c57e3a8a4cd7ddf114b27804ec01d
6 years, 3 months ago (2014-08-28 00:48:28 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a38fb5efd526a2278ab3b577c8c7881a3ad4d20
Cr-Commit-Position: refs/heads/master@{#292288}

Powered by Google App Engine
This is Rietveld 408576698