Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 516663004: Add a bunch of vlogs to RAF related calls in chrome. (Closed)

Created:
6 years, 3 months ago by Zhenyao Mo
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a bunch of vlogs to RAF related calls in chrome. This is to figure out which link in RAF is broken to cause flakiness. My current guess is the compositor scheduler issue, and these logs can confirm. BUG=393331 TEST=bots R=kbr@chromium.org TBR=brianderson@chromium.org Committed: https://crrev.com/1ca9422fc3ebbdc1370b5a75646924f0d02a8790 Cr-Commit-Position: refs/heads/master@{#292735}

Patch Set 1 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M cc/scheduler/scheduler.cc View 1 chunk +2 lines, -0 lines 2 comments Download
M cc/trees/thread_proxy.cc View 5 chunks +7 lines, -0 lines 2 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Zhenyao Mo
kbr: please take a look.
6 years, 3 months ago (2014-08-29 21:59:52 UTC) #2
Ken Russell (switch to Gerrit)
LGTM. One question. https://codereview.chromium.org/516663004/diff/20001/cc/scheduler/scheduler.cc File cc/scheduler/scheduler.cc (right): https://codereview.chromium.org/516663004/diff/20001/cc/scheduler/scheduler.cc#newcode641 cc/scheduler/scheduler.cc:641: case SchedulerStateMachine::ACTION_ANIMATE: I don't know this ...
6 years, 3 months ago (2014-08-29 22:25:43 UTC) #3
Zhenyao Mo
https://codereview.chromium.org/516663004/diff/20001/cc/scheduler/scheduler.cc File cc/scheduler/scheduler.cc (right): https://codereview.chromium.org/516663004/diff/20001/cc/scheduler/scheduler.cc#newcode641 cc/scheduler/scheduler.cc:641: case SchedulerStateMachine::ACTION_ANIMATE: On 2014/08/29 22:25:43, Ken Russell wrote: > ...
6 years, 3 months ago (2014-08-29 23:11:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/516663004/20001
6 years, 3 months ago (2014-08-29 23:13:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 70cdaf4a721efdeaa5e905ab711bdbd6571bf75f
6 years, 3 months ago (2014-08-30 00:35:35 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:12:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ca9422fc3ebbdc1370b5a75646924f0d02a8790
Cr-Commit-Position: refs/heads/master@{#292735}

Powered by Google App Engine
This is Rietveld 408576698