Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3269)

Unified Diff: content/public/common/resource_type.h

Issue 516663002: Introducing the OffDomainInclusionDetector to analyze resource requests for suspicious activity. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/resource_type.h
diff --git a/content/public/common/resource_type.h b/content/public/common/resource_type.h
index f71d953df4e4295a65554ed0554fae5b45ba8bd1..a77787ccd3f3a168573234baf05ac6cb9f671acb 100644
--- a/content/public/common/resource_type.h
+++ b/content/public/common/resource_type.h
@@ -9,26 +9,26 @@
namespace content {
-// Used in histograms, so please add new types at the end, and rename unused
-// entries to RESOURCETYPE_UNUSED_0, etc...
+// Used in histograms; explicitly assign each type and do not re-use old values.
enum ResourceType {
- RESOURCE_TYPE_MAIN_FRAME = 0, // top level page
- RESOURCE_TYPE_SUB_FRAME, // frame or iframe
- RESOURCE_TYPE_STYLESHEET, // a CSS stylesheet
- RESOURCE_TYPE_SCRIPT, // an external script
- RESOURCE_TYPE_IMAGE, // an image (jpg/gif/png/etc)
- RESOURCE_TYPE_FONT_RESOURCE, // a font
- RESOURCE_TYPE_SUB_RESOURCE, // an "other" subresource.
- RESOURCE_TYPE_OBJECT, // an object (or embed) tag for a plugin,
- // or a resource that a plugin requested.
- RESOURCE_TYPE_MEDIA, // a media resource.
- RESOURCE_TYPE_WORKER, // the main resource of a dedicated worker.
- RESOURCE_TYPE_SHARED_WORKER, // the main resource of a shared worker.
- RESOURCE_TYPE_PREFETCH, // an explicitly requested prefetch
- RESOURCE_TYPE_FAVICON, // a favicon
- RESOURCE_TYPE_XHR, // a XMLHttpRequest
- RESOURCE_TYPE_PING, // a ping request for <a ping>
- RESOURCE_TYPE_SERVICE_WORKER, // the main resource of a service worker.
+ RESOURCE_TYPE_MAIN_FRAME = 0, // top level page
+ RESOURCE_TYPE_SUB_FRAME = 1, // frame or iframe
+ RESOURCE_TYPE_STYLESHEET = 2, // a CSS stylesheet
+ RESOURCE_TYPE_SCRIPT = 3, // an external script
+ RESOURCE_TYPE_IMAGE = 4, // an image (jpg/gif/png/etc)
+ RESOURCE_TYPE_FONT_RESOURCE = 5, // a font
+ RESOURCE_TYPE_SUB_RESOURCE = 6, // an "other" subresource.
+ RESOURCE_TYPE_OBJECT = 7, // an object (or embed) tag for a plugin,
+ // or a resource that a plugin requested.
+ RESOURCE_TYPE_MEDIA = 8, // a media resource.
+ RESOURCE_TYPE_WORKER = 9, // the main resource of a dedicated
+ // worker.
+ RESOURCE_TYPE_SHARED_WORKER = 10, // the main resource of a shared worker.
+ RESOURCE_TYPE_PREFETCH = 11, // an explicitly requested prefetch
+ RESOURCE_TYPE_FAVICON = 12, // a favicon
+ RESOURCE_TYPE_XHR = 13, // a XMLHttpRequest
+ RESOURCE_TYPE_PING = 14, // a ping request for <a ping>
+ RESOURCE_TYPE_SERVICE_WORKER = 15, // the main resource of a service worker.
RESOURCE_TYPE_LAST_TYPE
};

Powered by Google App Engine
This is Rietveld 408576698