Adds the test expectations of home card bounds.

Adds the test expectations of home card bounds.

BUG=403813
R=oshima@chromium.org
TEST=athena_unittests

Committed: https://crrev.com/d2d81b54ffffd5e313d39d7fb5843399dba9a638
Cr-Commit-Position: refs/heads/master@{#292430}

[oshima, 2014-08-28 00:03:13]

https://codereview.chromium.org/516643005/diff/1/athena/home/home_card_impl.cc
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/516643005/diff/1/athena/home/home_card_impl.c...
athena/home/home_card_impl.cc:254: virtual aura::Window*
GetHomeCardWindowForTest() OVERRIDE;
nit: can they be const?

https://codereview.chromium.org/516643005/diff/1/athena/home/home_card_unitte...
File athena/home/home_card_unittest.cc (right):

https://codereview.chromium.org/516643005/diff/1/athena/home/home_card_unitte...
athena/home/home_card_unittest.cc:22: const int screen_height =
root_window()->bounds().height();
can you also test against work area?

https://codereview.chromium.org/516643005/diff/1/athena/home/public/home_card.h
File athena/home/public/home_card.h (right):

https://codereview.chromium.org/516643005/diff/1/athena/home/public/home_card...
athena/home/public/home_card.h:66: virtual aura::Window*
GetHomeCardWindowForTest() = 0;
Since the test reside in impl directory, can we keep it in HomeCardImpl?

[Jun Mukai, 2014-08-28 00:43:33]

https://codereview.chromium.org/516643005/diff/1/athena/home/home_card_impl.cc
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/516643005/diff/1/athena/home/home_card_impl.c...
athena/home/home_card_impl.cc:254: virtual aura::Window*
GetHomeCardWindowForTest() OVERRIDE;
On 2014/08/28 00:03:12, oshima wrote:
> nit: can they be const?

Done.

https://codereview.chromium.org/516643005/diff/1/athena/home/home_card_unitte...
File athena/home/home_card_unittest.cc (right):

https://codereview.chromium.org/516643005/diff/1/athena/home/home_card_unitte...
athena/home/home_card_unittest.cc:22: const int screen_height =
root_window()->bounds().height();
On 2014/08/28 00:03:12, oshima wrote:
> can you also test against work area?

Done.

https://codereview.chromium.org/516643005/diff/1/athena/home/public/home_card.h
File athena/home/public/home_card.h (right):

https://codereview.chromium.org/516643005/diff/1/athena/home/public/home_card...
athena/home/public/home_card.h:66: virtual aura::Window*
GetHomeCardWindowForTest() = 0;
On 2014/08/28 00:03:13, oshima wrote:
> Since the test reside in impl directory, can we keep it in HomeCardImpl?

Done.

[oshima, 2014-08-28 01:42:07]

lgtm with nits

https://codereview.chromium.org/516643005/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.h (right):

https://codereview.chromium.org/516643005/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.h:24: class Window;
shouldn't this be before namespace client? Ignore me if I'm wrong.

https://codereview.chromium.org/516643005/diff/20001/athena/home/public/home_...
File athena/home/public/home_card.h (right):

https://codereview.chromium.org/516643005/diff/20001/athena/home/public/home_...
athena/home/public/home_card.h:16: }
nit: remove this

[Jun Mukai, 2014-08-28 16:59:08]

https://codereview.chromium.org/516643005/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.h (right):

https://codereview.chromium.org/516643005/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.h:24: class Window;
On 2014/08/28 01:42:06, oshima wrote:
> shouldn't this be before namespace client? Ignore me if I'm wrong.

Done.

https://codereview.chromium.org/516643005/diff/20001/athena/home/public/home_...
File athena/home/public/home_card.h (right):

https://codereview.chromium.org/516643005/diff/20001/athena/home/public/home_...
athena/home/public/home_card.h:16: }
On 2014/08/28 01:42:06, oshima wrote:
> nit: remove this

Done.

[Jun Mukai, 2014-08-28 16:59:11]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-08-28 17:00:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/516643005/40001

[commit-bot: I haz the power, 2014-08-28 17:58:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/52998)

[commit-bot: I haz the power, 2014-08-28 18:55:11]

Committed patchset #3 (id:40001) as e27e20eefd611d2270d706e75b19bd82e06eebcf

[commit-bot: I haz the power, 2014-09-10 03:01:08]

Patchset 3 (id:??) landed as
https://crrev.com/d2d81b54ffffd5e313d39d7fb5843399dba9a638
Cr-Commit-Position: refs/heads/master@{#292430}