chrome/browser/extensions/location_bar_controller.h - Issue 516633002: Stop showing page actions in the location bar with redesign enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/location_bar_controller.h

Issue 516633002: Stop showing page actions in the location bar with redesign enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_action_test_util.cc ('K') | « chrome/browser/extensions/extension_test_notification_observer.cc ('k') | chrome/browser/extensions/location_bar_controller.cc » ('j') | chrome/browser/extensions/location_bar_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/location_bar_controller.h

diff --git a/chrome/browser/extensions/location_bar_controller.h b/chrome/browser/extensions/location_bar_controller.h

index 75bdda9693017f11cc1f3d482701005b73da5c84..d938d78ee766cabb5ccfeba35bb794b2389eea0e 100644

--- a/chrome/browser/extensions/location_bar_controller.h

+++ b/chrome/browser/extensions/location_bar_controller.h

@@ -52,6 +52,10 @@ class LocationBarController : public ExtensionRegistryObserver {

// The associated BrowserContext.

content::BrowserContext* browser_context_;

+ // Whether or not to show page actions in the location bar at all. (This is

+ // false with the toolbar redesign enabled.)

+ bool should_show_page_actions_;

// The ActiveScriptController, which could also add actions for extensions if

// they have a pending script.

scoped_ptr<ActiveScriptController> active_script_controller_;