Issue 51663003: ui: Move android C++ source files into base/android directory.

Issue 51663003: ui: Move android C++ source files into base/android directory. (Closed)

Created:
7 years, 1 month ago by tfarina

Modified:
5 years, 5 months ago

Reviewers:
bulach, Ben Goodger (Google)

CC:
chromium-reviews, benquan, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui: Move android C++ source files into base/android directory. BUG=299841 TEST=None, no functional changes. R=ben@chromium.org,bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232036

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -304 lines)			Patch
M	chrome/android/testshell/testshell_tab.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/platform_util_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/android/autofill/autofill_popup_view_android.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/android/javascript_app_modal_dialog_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/android/window_android_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/base/chrome_test_suite.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/app/android/library_loader_hooks.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/android/content_view_core_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/power_save_blocker_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/test/content_test_suite_base.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	ui/android/DEPS	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	ui/android/ui_jni_registrar.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	ui/android/ui_jni_registrar.cc	View	1 chunk	+0 lines, -32 lines	1 comment	Download
D	ui/android/view_android.h	View	1 chunk	+0 lines, -41 lines	0 comments	Download
D	ui/android/view_android.cc	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	ui/android/window_android.h	View	1 chunk	+0 lines, -48 lines	0 comments	Download
D	ui/android/window_android.cc	View	1 chunk	+0 lines, -62 lines	0 comments	Download
M	ui/base/DEPS	View	1 chunk	+2 lines, -1 line	0 comments	Download
A +	ui/base/android/OWNERS	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/base/android/ui_jni_registrar.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/base/android/ui_jni_registrar.cc	View	1 chunk	+3 lines, -3 lines	1 comment	Download
A +	ui/base/android/view_android.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/base/android/view_android.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	ui/base/android/window_android.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/base/android/window_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/shell_dialogs/select_file_dialog_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/snapshot/snapshot_android.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/test/test_suite.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/ui.gyp	View	5 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/51663003/1

7 years, 1 month ago (2013-10-30 18:45:50 UTC) #3

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=95240

7 years, 1 month ago (2013-10-30 23:14:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/51663003/1

7 years, 1 month ago (2013-10-31 00:04:54 UTC) #5

tfarina

7 years, 1 month ago (2013-11-12 19:26:35 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/51663003/diff/1/ui/android/ui_jni_registrar.cc
File ui/android/ui_jni_registrar.cc (left):

https://codereview.chromium.org/51663003/diff/1/ui/android/ui_jni_registrar.c...
ui/android/ui_jni_registrar.cc:13: #include
"ui/gfx/android/device_display_info.h"
These two gfx includes are unused, and thus can be removed. I'll remove them.

ui/gfx has its own gfx_jni_registrar.cc.

https://codereview.chromium.org/51663003/diff/1/ui/base/android/ui_jni_regist...
File ui/base/android/ui_jni_registrar.cc (right):

https://codereview.chromium.org/51663003/diff/1/ui/base/android/ui_jni_regist...
ui/base/android/ui_jni_registrar.cc:13: #include
"ui/gfx/android/device_display_info.h"
since these two includes are going away, we can keep ui_jni_registrar.cc in
ui/base, and rename it to ui_base_jni_registrar.cc

Expand Messages | Collapse Messages